From: Jonathan Corbet <corbet@lwn.net>
To: Daniel Drake <dsd@laptop.org>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] mmp-camera: specify XO-1.75 clock speed
Date: Wed, 16 May 2012 15:12:53 -0600 [thread overview]
Message-ID: <20120516151253.24d12245@lwn.net> (raw)
In-Reply-To: <20120515194331.77C519D401E@zog.reactivated.net>
On Tue, 15 May 2012 20:43:31 +0100 (BST)
Daniel Drake <dsd@laptop.org> wrote:
> Jon, is it OK to assume that XO-1.75 is the only mmp-camera user?
It's the only one I know of at the moment, certainly.
Even so, I think it would be a lot better to put this parameter into the
mmp_camera_platform_data structure instead of wiring it into the driver
source; it could then be set in olpc-xo-1-75.c with the other relevant
parameters. I won't oppose the inclusion of this patch, but...any chance
it could be done that way?
Thanks,
jon
next prev parent reply other threads:[~2012-05-16 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 19:43 [PATCH] mmp-camera: specify XO-1.75 clock speed Daniel Drake
2012-05-16 21:12 ` Jonathan Corbet [this message]
2012-05-16 21:15 ` Daniel Drake
2012-05-20 15:18 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516151253.24d12245@lwn.net \
--to=corbet@lwn.net \
--cc=dsd@laptop.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.