All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Joe Perches <joe@perches.com>, Jason Wang <jasowang@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ian.Campbell@citrix.com, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] tun: experimental zero copy tx support
Date: Wed, 16 May 2012 19:51:32 +0300	[thread overview]
Message-ID: <20120516165131.GB10769@redhat.com> (raw)
In-Reply-To: <1337181415.10741.18.camel@oc3660625478.ibm.com>

On Wed, May 16, 2012 at 08:16:55AM -0700, Shirley Ma wrote:
> On Mon, 2012-05-14 at 21:39 +0300, Michael S. Tsirkin wrote:
> > > Hello Mike,
> > > 
> > > Have you tested this patch? I think the difference between macvtap
> > and
> > > tap is tap forwarding the packet to bridge. The zerocopy is disabled
> > in
> > > this case.
> > > 
> > > Shirley
> > 
> > Testing in progress, but the patchset I pointed to enables
> > zerocopy with bridge. 
> 
> Hello Mike,
> 
> You meant this patch or another patchset for enabling bridge zerocopy?
> 
> I remembered we disabled forward skb zerocopy since the user space
> program might hold the buffers too long or forever.
> 
> In tap/bridge case, when the tx buffers will be released?
> 
> Thanks
> Shirley

It still fails some tests for me but maybe I'll post the whole
patchset so you can see how it works.

      reply	other threads:[~2012-05-16 16:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 15:52 [PATCH RFC] tun: experimental zero copy tx support Michael S. Tsirkin
2012-05-14 16:54 ` Stephen Hemminger
2012-05-14 17:04   ` Michael S. Tsirkin
2012-05-14 19:02     ` Eric Dumazet
2012-05-14 19:14       ` Michael S. Tsirkin
2012-05-14 19:17         ` Michael S. Tsirkin
2012-05-14 19:21         ` Eric Dumazet
2012-05-14 19:31           ` Michael S. Tsirkin
2012-05-15 18:00             ` Shirley Ma
2012-05-14 17:34 ` Shirley Ma
2012-05-14 18:39   ` Michael S. Tsirkin
2012-05-16 15:16     ` Shirley Ma
2012-05-16 16:51       ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120516165131.GB10769@redhat.com \
    --to=mst@redhat.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=joe@perches.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mashirle@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.