Re: [PATCH] nfsd: return 0 on reads of fault injection files

["J. Bruce Fields" <bfields@fieldses.org>]

On Thu, May 10, 2012 at 03:31:10PM -0400, Weston Andros Adamson wrote:
> debugfs read operations were returning the contents of an uninitialized u64.

Thanks, applied.

> 
> Signed-off-by: Weston Andros Adamson <dros@netapp.com>
> ---
> I found this while working on (forthcoming) fault injection tests for 
> CB_PATH_DOWN.

Did you ever confirm whether the latest nfsd is setting that flag when
it should be?

--b.

> 
>  fs/nfsd/fault_inject.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c
> index 46b7696..ab81144 100644
> --- a/fs/nfsd/fault_inject.c
> +++ b/fs/nfsd/fault_inject.c
> @@ -62,6 +62,7 @@ static int nfsd_inject_set(void *op_ptr, u64 val)
>  
>  static int nfsd_inject_get(void *data, u64 *val)
>  {
> +	*val = 0;
>  	return 0;
>  }
>  
> -- 
> 1.7.4.4
>