From: Tejun Heo <tj@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy: convert to delayed work and single-thread wq
Date: Thu, 17 May 2012 08:09:23 -0700 [thread overview]
Message-ID: <20120517150923.GH21275@google.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1205171705520.8796@pobox.suse.cz>
On Thu, May 17, 2012 at 05:06:41PM +0200, Jiri Kosina wrote:
> On Thu, 17 May 2012, Tejun Heo wrote:
>
> > > Umm. If there are abritrarily long things and these are serialized,
> > > then that workqueue is not good for putting floppy work on it either,
> > > is it? I don't think you can have it both ways.
> >
> > They're not being serialized.
>
> Then it's useless for this very purpose -- the sole purpose of the
> floppy_wq having as a single-threaded wq is to run all the work
> serialized.
>
> So the patch I have sent out this morning is the way to go.
Yeah, that seems to be my confusion here - I thought serialization is
necessary only for a work item. Can you please use
alloc_ordered_workqueue() instead of create_singlethread_workqueue()?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-17 15:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 7:36 [PATCH] floppy: convert to delayed work and single-thread wq Jiri Kosina
2012-05-16 14:57 ` Stephen Hemminger
2012-05-16 15:25 ` Linus Torvalds
2012-05-16 17:01 ` Tejun Heo
2012-05-16 19:37 ` Jiri Kosina
2012-05-16 19:43 ` Linus Torvalds
2012-05-16 19:47 ` Linus Torvalds
2012-05-16 19:51 ` Jiri Kosina
2012-05-16 19:53 ` Tejun Heo
2012-05-16 19:57 ` Jiri Kosina
2012-05-16 20:01 ` Tejun Heo
2012-05-16 20:24 ` Jiri Kosina
2012-05-16 20:29 ` Tejun Heo
2012-05-16 20:42 ` Linus Torvalds
2012-05-17 14:55 ` Tejun Heo
2012-05-17 15:03 ` Linus Torvalds
2012-05-17 15:06 ` Jiri Kosina
2012-05-17 15:09 ` Tejun Heo [this message]
2012-05-17 15:46 ` Jiri Kosina
2012-05-17 16:02 ` Tejun Heo
2012-05-16 20:44 ` Jiri Kosina
2012-05-17 15:06 ` Tejun Heo
2012-05-17 7:56 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517150923.GH21275@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.