From: "Jörn Engel" <joern@logfs.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Roland Dreier <roland@purestorage.com>,
target-devel@vger.kernel.org, Arun Easi <arun.easi@qlogic.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] qla_target: Check refcount in find_sess_by_*
Date: Thu, 17 May 2012 15:56:51 -0400 [thread overview]
Message-ID: <20120517195651.GD18067@logfs.org> (raw)
In-Reply-To: <1337289865.32217.307.camel@haakon2.linux-iscsi.org>
On Thu, 17 May 2012 14:24:25 -0700, Nicholas A. Bellinger wrote:
>
> Yes, I think it should be fine to move the loop_id and by fc_id lookup
> removal after the vha->hw->tgt.tgt_ops->clear_nacl_from_fcport_map()
> call within the call to qlt_unreg_sess() w/ hardware_lock held..
Just in case it wasn't clear from my other mail: no, that will not be
fine. Once the refcount drops to zero it must be impossible to hold
or obtain any new references. My patch didn't completely plug this
hole and neither does your proposal.
If that means the fast path just got slower: tough luck! Anyone can
write fast incorrect code. If the only way to write correct code is
to be slow, we shall be slow.
Jörn
--
Doubt is not a pleasant condition, but certainty is an absurd one.
-- Voltaire
prev parent reply other threads:[~2012-05-17 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120511143341.GA18753@logfs.org>
[not found] ` <20120517162600.GA18067@logfs.org>
2012-05-17 19:46 ` [PATCH] qla_target: Check refcount in find_sess_by_* Nicholas A. Bellinger
2012-05-17 20:49 ` Roland Dreier
2012-05-17 19:28 ` Jörn Engel
2012-05-17 21:05 ` Jörn Engel
2012-05-17 21:10 ` Jörn Engel
2012-05-18 2:02 ` Nicholas A. Bellinger
2012-05-18 1:15 ` Jörn Engel
2012-05-18 6:09 ` Nicholas A. Bellinger
2012-05-18 22:49 ` Jörn Engel
2012-05-19 1:26 ` Nicholas A. Bellinger
2012-05-21 22:18 ` Nicholas A. Bellinger
2012-05-17 21:24 ` Nicholas A. Bellinger
2012-05-17 19:56 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517195651.GD18067@logfs.org \
--to=joern@logfs.org \
--cc=arun.easi@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.