diff for duplicates of <20120517210633.400633E0621@localhost> diff --git a/a/1.txt b/N1/1.txt index e1eed41..7d0a8c6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -247,7 +247,7 @@ better to define a single table with a tuple for each line. > + int dir_bit; > + > + /* Some lines cannot be configured as input */ -> + if (offset = TS5500_LCD_EN) +> + if (offset == TS5500_LCD_EN) > + return -ENXIO; > + > + dir_reg = line_to_dir_map[offset]; @@ -328,11 +328,11 @@ as I described above. > +static int ts5500_gpio_to_irq(struct gpio_chip *chip, unsigned offset) > +{ > + /* Only a few lines are IRQ-capable */ -> + if (offset = TS5500_DIO1_13) +> + if (offset == TS5500_DIO1_13) > + return TS5500_DIO1_13_IRQ; -> + if (offset = TS5500_DIO2_13) +> + if (offset == TS5500_DIO2_13) > + return TS5500_DIO2_13_IRQ; -> + if (offset = TS5500_LCD_RS) +> + if (offset == TS5500_LCD_RS) > + return TS5500_LCD_RS_IRQ; > + > + /* IRQ line may be bridged with another DIO line from the same header */ @@ -382,7 +382,7 @@ using '-1' here. > + int ret; > + unsigned long flags; > + -> + if (pdev = NULL) +> + if (pdev == NULL) > + return -ENODEV; > + > + if (!request_region(0x7A, 3, "ts5500-gpio-DIO1")) { @@ -503,8 +503,3 @@ Please move the device registration to platform setup code. module_platform_driver() will replace some of the boilerplate. g. - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 3602dfd..66d7339 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01334276935-11258-1-git-send-email-vivien.didelot@savoirfairelinux.com\0" "ref\01334276935-11258-4-git-send-email-vivien.didelot@savoirfairelinux.com\0" "From\0Grant Likely <grant.likely@secretlab.ca>\0" - "Subject\0Re: [lm-sensors] [PATCH v6 3/3] gpio: TS-5500 GPIO support\0" - "Date\0Thu, 17 May 2012 21:06:33 +0000\0" + "Subject\0Re: [PATCH v6 3/3] gpio: TS-5500 GPIO support\0" + "Date\0Thu, 17 May 2012 15:06:33 -0600\0" "To\0Vivien Didelot <vivien.didelot@savoirfairelinux.com>" " x86@kernel.org\0" "Cc\0Jerome Oufella <jerome.oufella@savoirfairelinux.com>" @@ -266,7 +266,7 @@ "> +\tint dir_bit;\n" "> +\n" "> +\t/* Some lines cannot be configured as input */\n" - "> +\tif (offset = TS5500_LCD_EN)\n" + "> +\tif (offset == TS5500_LCD_EN)\n" "> +\t\treturn -ENXIO;\n" "> +\n" "> +\tdir_reg = line_to_dir_map[offset];\n" @@ -347,11 +347,11 @@ "> +static int ts5500_gpio_to_irq(struct gpio_chip *chip, unsigned offset)\n" "> +{\n" "> +\t/* Only a few lines are IRQ-capable */\n" - "> +\tif (offset = TS5500_DIO1_13)\n" + "> +\tif (offset == TS5500_DIO1_13)\n" "> +\t\treturn TS5500_DIO1_13_IRQ;\n" - "> +\tif (offset = TS5500_DIO2_13)\n" + "> +\tif (offset == TS5500_DIO2_13)\n" "> +\t\treturn TS5500_DIO2_13_IRQ;\n" - "> +\tif (offset = TS5500_LCD_RS)\n" + "> +\tif (offset == TS5500_LCD_RS)\n" "> +\t\treturn TS5500_LCD_RS_IRQ;\n" "> +\n" "> +\t/* IRQ line may be bridged with another DIO line from the same header */\n" @@ -401,7 +401,7 @@ "> +\tint ret;\n" "> +\tunsigned long flags;\n" "> +\n" - "> +\tif (pdev = NULL)\n" + "> +\tif (pdev == NULL)\n" "> +\t\treturn -ENODEV;\n" "> +\n" "> +\tif (!request_region(0x7A, 3, \"ts5500-gpio-DIO1\")) {\n" @@ -521,11 +521,6 @@ "\n" "module_platform_driver() will replace some of the boilerplate.\n" "\n" - "g.\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + g. -6f6f6792057ab54298fb67f560c6cb7282ac213a30f2dfd529ce29d50068e32c +d57c1898e247cff36dc80c462eae83b7542bf4d9bb3970067bc8e40380f4324b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.