All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seebach <peter.seebach@windriver.com>
To: Peter Seebach <peter.seebach@windriver.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [RFC PATCH 1/2] data_smart.py: Provide (optional) logging of variable modifications
Date: Fri, 18 May 2012 12:38:07 -0500	[thread overview]
Message-ID: <20120518123807.27ff41d9@wrlaptop> (raw)
In-Reply-To: <c46dd7e0f30c447a10df5a50c92217150e434996.1337361285.git.peter.seebach@windriver.com>

On Fri, 18 May 2012 12:27:39 -0500
Peter Seebach <peter.seebach@windriver.com> wrote:

> -        data.setVar('BBINCLUDED',bb.parse.get_file_depends(data))
> +        data.setVar('BBINCLUDED',bb.parse.get_file_depends(data),
> 'cooker.py', 'N/A')

kergoth points out, quite cleverly, that most of the changes that look
like this could be removed.  His suggestion:  Instead of defaulting to
"unknown" for the optional arguments, default to "use the Python stack
inspection to identify the caller."

This seems like a really good idea to me, because it allows us to get
meaningful data in nearly all the cases, while preserving the option of
specifying other values when, say, parsing config files.

Any objections to that as a plan for a v2?

-s
-- 
Listen, get this.  Nobody with a good compiler needs to be justified.



  reply	other threads:[~2012-05-18 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 17:27 [RFC PATCH 0/2] data_smart.py (mostly): Variable and include tracking! Peter Seebach
2012-05-18 17:27 ` [RFC PATCH 1/2] data_smart.py: Provide (optional) logging of variable modifications Peter Seebach
2012-05-18 17:38   ` Peter Seebach [this message]
2012-05-18 17:27 ` [RFC PATCH 2/2] data_smart.py: Track configuration file inclusions Peter Seebach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120518123807.27ff41d9@wrlaptop \
    --to=peter.seebach@windriver.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.