From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6955194796167724300==" MIME-Version: 1.0 From: Sergey Senozhatsky Subject: Re: [Powertop] [Discuss] [PATCH] iw: handle HAVE_LIBNL20 properly Date: Fri, 18 May 2012 16:54:16 +0300 Message-ID: <20120518135416.GE3074@swordfish> In-Reply-To: 4FB6513B.4040908@freemail.hu To: powertop@lists.01.org List-ID: --===============6955194796167724300== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On (05/18/12 15:40), N=C3=A9meth M=C3=A1rton wrote: > Doesn't compile either: > = > gcc -DHAVE_CONFIG_H -I. -I.. -D_FORTIFY_SOURCE=3D2 -g -O2 -MT tun= ing/powertop-iw.o -MD -MP -MF tuning/.deps/powertop-iw.Tpo -c -o tuning/pow= ertop-iw.o > `test -f 'tuning/iw.c' || echo './'`tuning/iw.c > tuning/iw.c: In function =E2=80=98set_power_save=E2=80=99: > tuning/iw.c:130: error: storage size of =E2=80=98ps_state=E2=80=99 isn=E2= =80=99t known > tuning/iw.c:132: error: =E2=80=98NL80211_PS_DISABLED=E2=80=99 undeclared = (first use in this function) > tuning/iw.c:132: error: (Each undeclared identifier is reported only once > tuning/iw.c:132: error: for each function it appears in.) > tuning/iw.c:134: error: =E2=80=98NL80211_PS_ENABLED=E2=80=99 undeclared (= first use in this function) > tuning/iw.c:136: error: =E2=80=98NL80211_ATTR_PS_STATE=E2=80=99 undeclare= d (first use in this function) > tuning/iw.c: In function =E2=80=98print_power_save_handler=E2=80=99: > tuning/iw.c:152: error: =E2=80=98NL80211_ATTR_PS_STATE=E2=80=99 undeclare= d (first use in this function) > tuning/iw.c:156: error: =E2=80=98NL80211_PS_ENABLED=E2=80=99 undeclared (= first use in this function) > tuning/iw.c:159: error: =E2=80=98NL80211_PS_DISABLED=E2=80=99 undeclared = (first use in this function) > tuning/iw.c: In function =E2=80=98__handle_cmd=E2=80=99: > tuning/iw.c:227: error: =E2=80=98NL80211_CMD_GET_POWER_SAVE=E2=80=99 unde= clared (first use in this function) > tuning/iw.c:230: error: =E2=80=98NL80211_CMD_SET_POWER_SAVE=E2=80=99 unde= clared (first use in this function) > make[3]: *** [tuning/powertop-iw.o] Error 1 > make[3]: Leaving directory `/mnt/store/nmarci/src/powertop/powertop2/powe= rtop/src' > make[2]: *** [all] Error 2 > make[2]: Leaving directory `/mnt/store/nmarci/src/powertop/powertop2/powe= rtop/src' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/mnt/store/nmarci/src/powertop/powertop2/powe= rtop' > make: *** [all] Error 2 > = > Looks like I have a linux/nl80211.h installed on my system which doesn't = contain > NL80211_PS_ENABLED, NL80211_PS_DISABLED, NL80211_ATTR_PS_STATE, NL80211_C= MD_GET_POWER_SAVE > and NL80211_CMD_SET_POWER_SAVE. These were added by commit > http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3Dco= mmitdiff;h=3Dffb9eb3d8b450c22bbbc688c6b630141ac476fd9 > = > The header file src/tuning/nl80211.h in powertop repository seems to be a= newer one. > Hm.. In that case solution is simple. --- src/tuning/iw.c | 1 + src/tuning/iw.h | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/tuning/iw.c b/src/tuning/iw.c index aeba3fd..68eb6dc 100644 --- a/src/tuning/iw.c +++ b/src/tuning/iw.c @@ -39,6 +39,7 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFT= WARE. #include #include = +#include "nl80211.h" #include #include #include diff --git a/src/tuning/iw.h b/src/tuning/iw.h index acf132d..6ea5a3d 100644 --- a/src/tuning/iw.h +++ b/src/tuning/iw.h @@ -33,12 +33,6 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOF= TWARE. */ = #include -#include -#include -#include -#include - -#include = #define ETH_ALEN 6 =20 --===============6955194796167724300==--