From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Colin Cross <ccross@android.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
arve@android.com, Rebecca Schultz Zavin <rebecca@android.com>,
Jesper Juhl <jj@chaosbits.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Boyd <sboyd@codeaurora.org>,
Thomas Meyer <thomas@m3y3r.de>,
Andrew Morton <akpm@linux-foundation.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com
Subject: Re: [PATCH 2/6] pstore/ram: Add console messages handling
Date: Fri, 18 May 2012 14:49:48 -0700 [thread overview]
Message-ID: <20120518214947.GA30293@lizard> (raw)
In-Reply-To: <CAMbhsRQVchQdnRTteriPqq7DZ68oROrWQr8eLjRtXGZ5q4_MrA@mail.gmail.com>
On Thu, May 17, 2012 at 11:28:22AM -0700, Colin Cross wrote:
> On Thu, May 17, 2012 at 1:40 AM, Anton Vorontsov
> <anton.vorontsov@linaro.org> wrote:
> > This is all straightforward: we just use the last region for
> > console logging. If there's just one region, we fall-back to
> > the old behaviour: just a oops/dumps logging.
> >
> > Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
>
> I don't think using the last region is the right way to handle this.
> We often use very large regions for ramconsole, up to 2MB. Using a
> single region would require a 2MB region for console and a 2MB region
> for oops, which is far too large.
Yeah, I agree. I planned to take care of it later, as this would
involve touching more code. But OK, let's do this right away.
Thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2012-05-18 21:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 8:37 [PATCH v2 0/6] Merge ram_console into pstore Anton Vorontsov
2012-05-17 8:40 ` [PATCH 1/6] pstore: Add console log messages support Anton Vorontsov
2012-05-17 16:31 ` Kees Cook
2012-05-17 8:40 ` [PATCH 2/6] pstore/ram: Add console messages handling Anton Vorontsov
2012-05-17 16:38 ` Kees Cook
2012-05-17 18:28 ` Colin Cross
2012-05-18 21:49 ` Anton Vorontsov [this message]
2012-05-17 8:40 ` [PATCH 3/6] pstore/ram_core: Silence some printks Anton Vorontsov
2012-05-17 16:38 ` Kees Cook
2012-05-17 8:41 ` [PATCH 4/6] pstore/ram: Add some more documentation and examples Anton Vorontsov
2012-05-17 8:41 ` [PATCH 5/6] staging/android: Remove ram_console driver Anton Vorontsov
2012-05-17 8:41 ` [PATCH 6/6] pstore/ram_core: Remove now unused code Anton Vorontsov
2012-05-17 16:39 ` Kees Cook
2012-05-17 18:42 ` [PATCH v2 0/6] Merge ram_console into pstore Colin Cross
2012-05-18 21:47 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 12:53 [PATCH " Anton Vorontsov
2012-05-16 12:56 ` [PATCH 2/6] pstore/ram: Add console messages handling Anton Vorontsov
2012-05-16 15:30 ` Shuah Khan
2012-05-16 22:20 ` Anton Vorontsov
2012-05-16 16:45 ` Kees Cook
2012-05-16 22:28 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518214947.GA30293@lizard \
--to=anton.vorontsov@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rebecca@android.com \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.