From: Grant Likely <grant.likely@secretlab.ca>
To: Andreas Schallenberg <Andreas.Schallenberg@3alitytechnica.com>,
linus.walleij@stericsson.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GPIO/TCA6424: merge I2C transactions, remove cast
Date: Fri, 18 May 2012 17:47:54 -0600 [thread overview]
Message-ID: <20120518234754.1DD013E07C8@localhost> (raw)
In-Reply-To: <20120518234410.E079C3E07C8@localhost>
On Fri, 18 May 2012 17:44:10 -0600, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Fri, 18 May 2012 17:01:36 +0200, Andreas Schallenberg <Andreas.Schallenberg@3alitytechnica.com> wrote:
> > From 1a80280e20dfef57c6bc6429e5bdf7e10d10fda9 Mon Sep 17 00:00:00 2001
> > From: Andreas Schallenberg <Andreas.Schallenberg@3alitytechnica.com>
> > Date: Fri, 18 May 2012 16:20:31 +0200
> > Subject: [PATCH] GPIO/TCA6424: merge I2C transactions, remove cast
> >
> > This is a follow-up to "[PATCH v2] Add support for TCA6424":
> > - Use 3 byte transfers instead of two separate transfers (2+1 byte)
> > - An unnecessary cast removed
> >
> > Please check especially if endianness conversion is done the way it should be.
>
> It works I suppose. Personally, I'd explicitly use a byte array, but
> I'll apply this patch as-is anyway.
Patch is damaged and cannot be applied (line wraps and tabs converted
to spaces). Please check your mailer (please use git send-email) and
repost.
g.
prev parent reply other threads:[~2012-05-18 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 15:01 [PATCH] GPIO/TCA6424: merge I2C transactions, remove cast Andreas Schallenberg
2012-05-18 23:44 ` Grant Likely
2012-05-18 23:47 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518234754.1DD013E07C8@localhost \
--to=grant.likely@secretlab.ca \
--cc=Andreas.Schallenberg@3alitytechnica.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.