diff for duplicates of <20120519202140.7B0973E03B8@localhost> diff --git a/a/1.txt b/N1/1.txt index 7b5a6b9..c8ec4e7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -84,7 +84,7 @@ irq_descs, or strict map for allocating a specific range of irqs. > + pr_debug("irq: irq_create_identity_mapping(0x%p, 0x%lx)\n", > + domain, hwirq); > + -> + if (domain = NULL) +> + if (domain == NULL) > + domain = irq_default_domain; This is a new API, and I'm not a fan of the irq_default_domain usage @@ -94,7 +94,7 @@ domain it is requesting from. If a default domain really is needed, then there it should be explicit for the caller to find the default domain and then pass that in to this function. -> + if (domain = NULL) { +> + if (domain == NULL) { > + WARN_ON(1); > + return 0; > + } diff --git a/a/content_digest b/N1/content_digest index 535be55..0f6f450 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,10 +2,11 @@ "ref\01337407908-7421-7-git-send-email-lethal@linux-sh.org\0" "From\0Grant Likely <grant.likely@secretlab.ca>\0" "Subject\0Re: [PATCH 6/8] irqdomain: Support identity mapped VIRQ allocation.\0" - "Date\0Sat, 19 May 2012 20:21:40 +0000\0" + "Date\0Sat, 19 May 2012 14:21:40 -0600\0" "To\0Paul Mundt <lethal@linux-sh.org>\0" "Cc\0linux-sh@vger.kernel.org" - " linux-kernel@vger.kernel.org\0" + linux-kernel@vger.kernel.org + " Paul Mundt <lethal@linux-sh.org>\0" "\00:1\0" "b\0" "On Sat, 19 May 2012 15:11:46 +0900, Paul Mundt <lethal@linux-sh.org> wrote:\n" @@ -94,7 +95,7 @@ "> +\tpr_debug(\"irq: irq_create_identity_mapping(0x%p, 0x%lx)\\n\",\n" "> +\t\t domain, hwirq);\n" "> +\n" - "> +\tif (domain = NULL)\n" + "> +\tif (domain == NULL)\n" "> +\t\tdomain = irq_default_domain;\n" "\n" "This is a new API, and I'm not a fan of the irq_default_domain usage\n" @@ -104,7 +105,7 @@ "then there it should be explicit for the caller to find the default\n" "domain and then pass that in to this function.\n" "\n" - "> +\tif (domain = NULL) {\n" + "> +\tif (domain == NULL) {\n" "> +\t\tWARN_ON(1);\n" "> +\t\treturn 0;\n" "> +\t}\n" @@ -143,4 +144,4 @@ "Grant Likely, B.Sc, P.Eng.\n" Secret Lab Technologies, Ltd. -6f3a047d5d6d20011dbee708d08c7bea967730ca8f60c2340496a3c07c91fdea +a6fecf4e31242c786faadbdc01af63774281ced8aa68ad2f011d8f9930c27241
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.