From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't clobber the pipe param in sanitize_modesetting Date: Sat, 19 May 2012 22:47:19 +0200 Message-ID: <20120519204719.GC4738@phenom.ffwll.local> References: <1336939976_9843@CP5-2952> <1336940965-7695-1-git-send-email-daniel.vetter@ffwll.ch> <1336941249_10082@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A1E5A0C34 for ; Sat, 19 May 2012 13:46:02 -0700 (PDT) Received: by wibhm14 with SMTP id hm14so931944wib.12 for ; Sat, 19 May 2012 13:46:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1336941249_10082@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development , "the regression was Cc: stable, too" List-Id: intel-gfx@lists.freedesktop.org On Sun, May 13, 2012 at 09:33:42PM +0100, Chris Wilson wrote: > On Sun, 13 May 2012 22:29:25 +0200, Daniel Vetter wrote: > > ... we need it later on in the function to clean up pipe <-> plane > > associations. This regression has been introduced in > > > > commit f47166d2b0001fcb752b40c5a2d4db986dfbea68 > > Author: Chris Wilson > > Date: Thu Mar 22 15:00:50 2012 +0000 > > > > drm/i915: Sanitize BIOS debugging bits from PIPECONF > > > > Spotted by staring at debug output of an (as it turns out) totally > > unrelated bug. > > > > v2: I've totally failed to do the s/pipe/i/ correctly, spotted by > > Chris Wilson. > > > > Cc: Chris Wilson > > Cc: stable@kernel.org (the regression was Cc: stable, too) > > Signed-Off-by: Daniel Vetter > Reviewed-by: Chris Wilson Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48