From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Convert BUG_ON(!pll->active) and
 friends to a WARN
Date: Sat, 19 May 2012 23:09:36 +0200
Message-ID: <20120519210936.GD4738@phenom.ffwll.local>
References: <1336899249-2612-1-git-send-email-chris@chris-wilson.co.uk>
	<1336936572-19548-1-git-send-email-chris@chris-wilson.co.uk>
	<CAC7Lmntub02Em8FpgOCF-WBdymPekzk=kcknL0mZY6AJA_LaGQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 12C6CA0B31
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 19 May 2012 14:08:18 -0700 (PDT)
Received: by wibhm14 with SMTP id hm14so890374wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 19 May 2012 14:08:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAC7Lmntub02Em8FpgOCF-WBdymPekzk=kcknL0mZY6AJA_LaGQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, May 13, 2012 at 08:51:41PM -0300, Eugeni Dodonov wrote:
> On Sun, May 13, 2012 at 4:16 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Turn a fatal lockup into a merely blank display with lots of shouty
> > messages.
> >
> > v2: Whilst in the area, convert the other BUG_ON into less fatal errors.
> > In particular, note that we may be called on a PCH platform not using
> > PLLs, such as Haswell, and so we do not always want to BUG_ON(!pll)
> 
> I think that we need to keep in mind that we can have Haswell+PPT
> combination, but I don't know what will happen in this case yet.
> 
> So I'd suggest adding a:
> 
> WARN_ON(pll == NULL && !HAS_PCH_LPT(dev));
> 
> as well somewhere in the checks. What do you think?

Sounds sensible. Care to stitch together that patch?
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48