From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). Date: Sun, 20 May 2012 00:08:01 -0600 Message-ID: <20120520060802.03CE73E03B8@localhost> References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f51.google.com (mail-pb0-f51.google.com [209.85.160.51]) by alsa0.perex.cz (Postfix) with ESMTP id 05DD0248D8 for ; Sun, 20 May 2012 08:08:04 +0200 (CEST) Received: by pbbrp16 with SMTP id rp16so7050680pbb.38 for ; Sat, 19 May 2012 23:08:03 -0700 (PDT) In-Reply-To: <20120520055436.13AF03E03B8@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: David Daney , devicetree-discuss@lists.ozlabs.org, Rob Herring , spi-devel-general@lists.sourceforge.net Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Mark Brown , David Daney , Takashi Iwai , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , linuxppc-dev@lists.ozlabs.org, Timur Tabi List-Id: alsa-devel@alsa-project.org On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: > On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > > From: David Daney > > > > When generating MODALIASes, it is convenient to add things like "spi:" > > or "i2c:" to the front of the strings. This allows the standard > > modprobe to find the right driver when automatically populating bus > > children from the device tree structure. > > > > Add a prefix parameter, and adjust callers. For > > of_register_spi_devices() use the "spi:" prefix. > > > > Signed-off-by: David Daney > > Applied, thanks. Some notes below... Wait... why is this necessary? The module type prefix isn't stored in the modalias value for any other bus type as far as I can see, and with this series it appears that the "spi:" prefix may or may not be present in the modalias. That doesn't look right. Why isn't prefixing spi: at uevent time sufficient? IIUC, modprobe depends on either UEVENT or the modalias attribute to know which driver to probe. It does look like the attribute is missing the spi: prefix though. Does the following change work instead of these two patches? diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 3d8f662..da8aac7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) { const struct spi_device *spi = to_spi_device(dev); - return sprintf(buf, "%s\n", spi->modalias); + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); } So, I've dropped this patch from my tree. If the change above works for you then I'll push it out. g. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 20 May 2012 08:08:13 +0200 (CEST) Received: from mail-pb0-f49.google.com ([209.85.160.49]:48895 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903258Ab2ETGIK (ORCPT ); Sun, 20 May 2012 08:08:10 +0200 Received: by pbbrq13 with SMTP id rq13so6424168pbb.36 for ; Sat, 19 May 2012 23:08:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:subject:to:cc:in-reply-to:references:date:message-id :x-gm-message-state; bh=/h5uIm4kc5mZVZUNzpnVm9bFN5A9sojgcxUBOtYAbqg=; b=VR2tWA8AzdzDNHfWcz65oS9LcuTWuVb9XAPK1Olf2r89bI3uZVXx4zKeGUaLr8L11a qPqd9vG1Uz/I16bKNaVDRE6mysSVbdpGThU3XnVmj54rQocO6or5Mr+iwc/DN9UPUdPT 6S79S3+3p5pDDHkSRTT9mCB8So4XsYsNqqqNmCeMiaGsjpFsi7nESq9avo462isHo1s5 Gosga0sT/mPffI5dSc1qJI66j97ARYuCXs/F1DG02yQvoJcjIoSXH7wNng5o/fQkabiz Fz1+3iUuUDJP0GsMW/ydwQ9K4Tq+QJSc+PBuyMS0YMRwrjCuuTbRevadDRIYl5q7BU62 BnQQ== Received: by 10.68.200.193 with SMTP id ju1mr52235368pbc.90.1337494083721; Sat, 19 May 2012 23:08:03 -0700 (PDT) Received: from localhost (S0106d8b37715ee14.cg.shawcable.net. [68.146.14.168]) by mx.google.com with ESMTPS id rv8sm13214960pbc.64.2012.05.19.23.08.02 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 19 May 2012 23:08:03 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 03CE73E03B8; Sun, 20 May 2012 00:08:01 -0600 (MDT) From: Grant Likely Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). To: David Daney , devicetree-discuss@lists.ozlabs.org, Rob Herring , spi-devel-general@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-doc@vger.kernel.org, David Daney , Liam Girdwood , Timur Tabi , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <20120520055436.13AF03E03B8@localhost> References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> Date: Sun, 20 May 2012 00:08:01 -0600 Message-Id: <20120520060802.03CE73E03B8@localhost> X-Gm-Message-State: ALoCoQmG2F0AiZzerau5HDxVJSXz4fbAkJAE40tkSTaLyqHjBA+TjJulo5v8OyWeP8pOuT9uL5gD X-archive-position: 33382 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: grant.likely@secretlab.ca Precedence: bulk X-list: linux-mips Return-Path: On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: > On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > > From: David Daney > > > > When generating MODALIASes, it is convenient to add things like "spi:" > > or "i2c:" to the front of the strings. This allows the standard > > modprobe to find the right driver when automatically populating bus > > children from the device tree structure. > > > > Add a prefix parameter, and adjust callers. For > > of_register_spi_devices() use the "spi:" prefix. > > > > Signed-off-by: David Daney > > Applied, thanks. Some notes below... Wait... why is this necessary? The module type prefix isn't stored in the modalias value for any other bus type as far as I can see, and with this series it appears that the "spi:" prefix may or may not be present in the modalias. That doesn't look right. Why isn't prefixing spi: at uevent time sufficient? IIUC, modprobe depends on either UEVENT or the modalias attribute to know which driver to probe. It does look like the attribute is missing the spi: prefix though. Does the following change work instead of these two patches? diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 3d8f662..da8aac7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) { const struct spi_device *spi = to_spi_device(dev); - return sprintf(buf, "%s\n", spi->modalias); + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); } So, I've dropped this patch from my tree. If the change above works for you then I'll push it out. g. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f51.google.com (mail-pz0-f51.google.com [209.85.210.51]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C0ED9B6FAB for ; Sun, 20 May 2012 16:08:05 +1000 (EST) Received: by dajt11 with SMTP id t11so6917095daj.38 for ; Sat, 19 May 2012 23:08:03 -0700 (PDT) Sender: Grant Likely From: Grant Likely Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). To: David Daney , devicetree-discuss@lists.ozlabs.org, Rob Herring , spi-devel-general@lists.sourceforge.net In-Reply-To: <20120520055436.13AF03E03B8@localhost> References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> Date: Sun, 20 May 2012 00:08:01 -0600 Message-Id: <20120520060802.03CE73E03B8@localhost> Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Mark Brown , David Daney , Takashi Iwai , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, Timur Tabi List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: > On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > > From: David Daney > > > > When generating MODALIASes, it is convenient to add things like "spi:" > > or "i2c:" to the front of the strings. This allows the standard > > modprobe to find the right driver when automatically populating bus > > children from the device tree structure. > > > > Add a prefix parameter, and adjust callers. For > > of_register_spi_devices() use the "spi:" prefix. > > > > Signed-off-by: David Daney > > Applied, thanks. Some notes below... Wait... why is this necessary? The module type prefix isn't stored in the modalias value for any other bus type as far as I can see, and with this series it appears that the "spi:" prefix may or may not be present in the modalias. That doesn't look right. Why isn't prefixing spi: at uevent time sufficient? IIUC, modprobe depends on either UEVENT or the modalias attribute to know which driver to probe. It does look like the attribute is missing the spi: prefix though. Does the following change work instead of these two patches? diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 3d8f662..da8aac7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) { const struct spi_device *spi = to_spi_device(dev); - return sprintf(buf, "%s\n", spi->modalias); + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); } So, I've dropped this patch from my tree. If the change above works for you then I'll push it out. g.