From: Tejun Heo <tj@kernel.org>
To: Asias He <asias@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 1/5] block: Introduce q->abort_queue_fn()
Date: Mon, 21 May 2012 08:42:13 -0700 [thread overview]
Message-ID: <20120521154213.GB6549@google.com> (raw)
In-Reply-To: <1337591313-26333-1-git-send-email-asias@redhat.com>
On Mon, May 21, 2012 at 05:08:29PM +0800, Asias He wrote:
> When user hot-unplug a disk which is busy serving I/O, __blk_run_queue
> might be unable to drain all the requests. As a result, the
> blk_drain_queue() would loop forever and blk_cleanup_queue would not
> return. So hot-unplug will fail.
>
> This patch adds a callback in blk_drain_queue() for low lever driver to
> abort requests.
>
> Currently, this is useful for virtio-blk to do cleanup in hot-unplug.
Why is this necessary? virtio-blk should know that the device is gone
and fail in-flight / new commands. That's what other drivers do.
What makes virtio-blk different?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-21 15:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 9:08 [RFC PATCH 1/5] block: Introduce q->abort_queue_fn() Asias He
2012-05-21 9:08 ` [RFC PATCH 2/5] block: Do not stop draining if waitqueue is not empty Asias He
2012-05-21 15:39 ` Tejun Heo
2012-05-22 6:48 ` Asias He
2012-05-22 15:07 ` Tejun Heo
2012-05-23 14:54 ` Asias He
2012-05-25 1:16 ` Asias He
2012-05-28 0:30 ` Tejun Heo
2012-05-28 3:39 ` Asias He
2012-05-21 9:08 ` [RFC PATCH 3/5] virtio-blk: Call del_gendisk() before disable guest kick Asias He
2012-05-21 9:08 ` [RFC PATCH 4/5] virtio-blk: Use q->abort_queue_fn() to abort requests Asias He
2012-05-21 9:08 ` [RFC PATCH 5/5] virtio-blk: Use block layer provided spinlock Asias He
2012-05-21 20:59 ` Michael S. Tsirkin
2012-05-22 8:22 ` Asias He
2012-05-21 15:42 ` Tejun Heo [this message]
2012-05-22 7:30 ` [RFC PATCH 1/5] block: Introduce q->abort_queue_fn() Asias He
2012-05-22 15:14 ` Tejun Heo
2012-05-23 15:04 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521154213.GB6549@google.com \
--to=tj@kernel.org \
--cc=asias@redhat.com \
--cc=axboe@kernel.dk \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.