From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Add basic support for new Marvell Armada SoC family
Date: Mon, 21 May 2012 19:27:34 +0200 [thread overview]
Message-ID: <20120521172734.GG12741@lunn.ch> (raw)
In-Reply-To: <20120521153922.GO24238@titan.lakedaemon.net>
On Mon, May 21, 2012 at 11:39:22AM -0400, Jason Cooper wrote:
> On Mon, May 21, 2012 at 11:40:52AM +0200, Andrew Lunn wrote:
> > > Personally, my view is leave it alone and just add a new machine
> > > directory.
>
> I agree, see my response to Russell.
>
> > > Pushing items around doesn't really help the amount of code in the
> > > kernel, the organisation does not add more than a line or two to the
> > > Makefiles.
> >
> > It does however make it easier to see where the same code has been
> > cut/paste. There is some stuff in the various Orion mach- directories
> > which is repeated 4 times. The Armada XP port wanted to add a 5th
> > copy. All this repeated code needs to be put into plat-orion.
>
> Does my suggested layout/migration path cover your concerns?
I actually like Arnd patch of putting everything into one
directory. I've been building on that patch removing duplicate code,
modifying the address map to make it as similar as possible, removing
defines which are the same on all SoCs etc. I think actually having
everything spread out is what has contributed to the X copies and
needless incompatibilities.
My vote is to commit Arnd patch as is.
Andrew
next prev parent reply other threads:[~2012-05-21 17:27 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 8:54 [PATCH] arm: Add basic support for new Marvell Armada SoC family Thomas Petazzoni
2012-05-15 8:54 ` [PATCH 1/8] arm: mach-armada: add headers Thomas Petazzoni
2012-05-15 9:16 ` Ben Dooks
2012-05-15 10:57 ` Ben Dooks
2012-05-15 13:21 ` Rob Herring
2012-05-15 18:42 ` Nicolas Pitre
2012-05-15 8:54 ` [PATCH 2/8] arm: mach-armada: add source files Thomas Petazzoni
2012-05-15 9:12 ` Andrew Lunn
2012-05-15 9:17 ` Thomas Petazzoni
2012-05-15 9:54 ` Ben Dooks
2012-05-15 10:00 ` Arnaud Patard (Rtp)
2012-05-15 10:37 ` Ben Dooks
2012-05-15 9:27 ` Andrew Lunn
2012-05-15 9:54 ` Ben Dooks
2012-05-15 12:46 ` Lior Amsalem
2012-05-15 9:46 ` Ben Dooks
2012-05-15 9:59 ` Gregory CLEMENT
2012-05-15 10:03 ` Andrew Lunn
2012-05-19 6:21 ` Grant Likely
2012-05-16 14:27 ` Ben Dooks
2012-05-16 15:06 ` Ben Dooks
2012-05-15 8:54 ` [PATCH 3/8] arm: mach-armada: add documentation for new device tree bindings Thomas Petazzoni
2012-05-15 11:31 ` Ben Dooks
2012-05-15 8:54 ` [PATCH 4/8] arm: mach-armada: add compilation/configuration changes Thomas Petazzoni
2012-05-15 8:54 ` [PATCH 5/8] arm: mach-armada: add support for Armada 370 board with device tree Thomas Petazzoni
2012-05-15 8:54 ` [PATCH 6/8] arm: mach-armada: add support for Armada XP " Thomas Petazzoni
2012-05-15 9:58 ` Ben Dooks
2012-05-15 13:10 ` Lior Amsalem
2012-05-15 13:19 ` Andrew Lunn
2012-05-15 14:23 ` Arnd Bergmann
2012-05-15 18:37 ` Nicolas Pitre
2012-05-17 23:31 ` Jason Cooper
2012-05-15 13:33 ` Ben Dooks
2012-05-15 13:31 ` Rob Herring
2012-05-15 13:53 ` Ben Dooks
2012-05-15 14:16 ` Thomas Petazzoni
2012-05-15 14:25 ` Arnd Bergmann
2012-05-15 14:29 ` Thomas Petazzoni
2012-05-15 14:35 ` Ben Dooks
2012-05-15 14:53 ` Rob Herring
2012-05-15 15:01 ` Ben Dooks
2012-05-15 15:30 ` Russell King - ARM Linux
2012-05-15 14:32 ` Ben Dooks
2012-05-15 14:37 ` Arnd Bergmann
2012-05-15 16:31 ` Stephen Warren
2012-05-15 19:41 ` Arnd Bergmann
2012-05-15 14:58 ` Thomas Petazzoni
2012-05-15 15:07 ` Ben Dooks
2012-05-15 15:32 ` Arnd Bergmann
2012-05-15 15:46 ` Thomas Petazzoni
2012-05-15 21:22 ` Rob Herring
2012-05-15 15:49 ` Ben Dooks
2012-05-15 19:06 ` Arnd Bergmann
2012-05-15 15:41 ` Russell King - ARM Linux
2012-05-15 15:59 ` Ben Dooks
2012-05-15 16:03 ` Russell King - ARM Linux
2012-05-17 23:35 ` Jason Cooper
2012-05-18 2:12 ` Rob Herring
2012-05-22 12:00 ` Ben Dooks
2012-05-22 13:34 ` Jason Cooper
2012-05-22 17:06 ` Arnd Bergmann
2012-05-23 2:02 ` Haojian Zhuang
2012-05-15 8:54 ` [PATCH 7/8] arm: mach-armada: add defconfig Thomas Petazzoni
2012-05-15 9:58 ` Ben Dooks
2012-05-15 12:54 ` Thomas Petazzoni
2012-05-15 8:54 ` [PATCH 8/8] arm: mach-armada: add entry to MAINTAINERS Thomas Petazzoni
2012-05-15 9:18 ` [PATCH] arm: Add basic support for new Marvell Armada SoC family Andrew Lunn
2012-05-15 9:44 ` Thomas Petazzoni
2012-05-15 9:51 ` Ben Dooks
2012-05-15 9:55 ` Thomas Petazzoni
2012-05-15 13:15 ` Andrew Lunn
2012-05-15 14:35 ` Rob Herring
2012-05-15 14:44 ` Thomas Petazzoni
2012-05-15 15:27 ` Arnd Bergmann
2012-05-15 15:39 ` Thomas Petazzoni
2012-05-15 16:26 ` Arnd Bergmann
2012-05-15 21:35 ` Arnd Bergmann
2012-05-16 0:25 ` Nicolas Pitre
2012-05-16 5:07 ` Andrew Lunn
2012-05-16 6:57 ` Arnd Bergmann
2012-05-16 6:57 ` Haojian Zhuang
2012-05-16 17:30 ` Andrew Lunn
2012-05-15 18:20 ` Nicolas Pitre
2012-05-15 16:22 ` Andrew Lunn
2012-05-15 16:25 ` Ben Dooks
2012-05-15 16:30 ` Andrew Lunn
2012-05-15 16:37 ` Ben Dooks
2012-05-16 11:12 ` Lior Amsalem
2012-05-16 11:36 ` Andrew Lunn
2012-05-16 12:00 ` Arnd Bergmann
2012-05-16 14:55 ` Lior Amsalem
2012-05-16 15:20 ` Nicolas Pitre
2012-05-16 15:28 ` Arnd Bergmann
2012-05-16 16:49 ` Nicolas Pitre
2012-05-16 19:46 ` Arnd Bergmann
2012-05-16 20:20 ` Nicolas Pitre
2012-05-16 20:34 ` Arnd Bergmann
2012-05-18 19:20 ` Jason Cooper
2012-05-22 12:03 ` Ben Dooks
2012-05-18 19:18 ` Jason Cooper
2012-05-18 20:44 ` Arnd Bergmann
2012-05-18 22:51 ` Nicolas Pitre
2012-05-19 11:24 ` Jason Cooper
2012-05-19 17:32 ` Arnd Bergmann
2012-05-20 0:45 ` Nicolas Pitre
2012-05-20 9:55 ` Russell King - ARM Linux
2012-05-20 10:58 ` Arnd Bergmann
2012-05-20 11:10 ` Russell King - ARM Linux
2012-05-21 1:30 ` Jason Cooper
2012-05-21 7:58 ` Arnd Bergmann
2012-05-21 9:30 ` Russell King - ARM Linux
2012-05-21 15:35 ` Jason Cooper
2012-05-21 16:11 ` Russell King - ARM Linux
2012-05-21 16:58 ` Jason Cooper
2012-05-21 19:40 ` Arnd Bergmann
2012-05-22 14:25 ` Nicolas Pitre
2012-05-22 16:03 ` Jason Cooper
2012-05-22 16:06 ` Ben Dooks
2012-05-22 16:16 ` Jason Cooper
2012-05-24 11:18 ` Ben Dooks
2012-05-22 17:09 ` Arnd Bergmann
2012-05-21 8:55 ` Ben Dooks
2012-05-21 9:16 ` Andrew Lunn
2012-05-21 9:27 ` Ben Dooks
2012-05-21 9:40 ` Andrew Lunn
2012-05-21 15:39 ` Jason Cooper
2012-05-21 17:27 ` Andrew Lunn [this message]
2012-05-15 11:06 ` Arnd Bergmann
2012-05-15 12:50 ` Thomas Petazzoni
2012-05-15 16:03 ` Ben Dooks
2012-05-15 11:18 ` Ben Dooks
2012-05-15 12:26 ` Lior Amsalem
2012-05-15 12:51 ` Thomas Petazzoni
2012-05-15 11:20 ` Ben Dooks
2012-05-15 12:29 ` Lior Amsalem
2012-05-15 14:55 ` Ben Dooks
2012-05-15 15:00 ` Thomas Petazzoni
2012-05-15 15:07 ` Ben Dooks
2012-05-15 15:36 ` Ben Dooks
2012-05-15 15:39 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521172734.GG12741@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.