From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: don't return -ENXIO from gmbus
	xfer
Date: Mon, 21 May 2012 20:20:42 +0200
Message-ID: <20120521182042.GD4970@phenom.ffwll.local>
References: <1336974981-5176-1-git-send-email-daniel.vetter@ffwll.ch>
	<1337458212-15791-1-git-send-email-daniel.vetter@ffwll.ch>
	<20120520151916.GB5145@phenom.ffwll.local>
	<CAGS+omCnwFf-uKiQewMnprPJ5maSjS9ROeyoRTiYd_JRBjSBiQ@mail.gmail.com>
	<20120520181553.GE5145@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0A1EE9E78A
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 May 2012 11:19:23 -0700 (PDT)
Received: by wibhm14 with SMTP id hm14so2044267wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 May 2012 11:19:23 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120520181553.GE5145@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, May 20, 2012 at 08:16:46PM +0200, Daniel Vetter wrote:
> On Sun, May 20, 2012 at 11:07:46AM -0700, Daniel Kurtz wrote:
> > Since this reported issue is happening in this double error path, I'd
> > rather a patch that fixes it without disabling the more generic NAK
> > path.  Maybe something like this:
> 
> Hm, good suggestion. This way, if we get a NAK but no issues later on,
> we'll still fail faster if gmbus detected that no device is responding.
> Which should speed up boot a bit. I'll run this past the bug reporter.

We're lucky, and the modified patch tested ok by the bug reporter. I'll
follow up with v2, please smash your r-b onto it if you're satisfied.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48