From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] fs: Fix NULL pointer dereference at copy_mnt_ns().
Date: Mon, 21 May 2012 19:35:13 +0100
Message-ID: <20120521183513.GD11775@ZenIV.linux.org.uk>
References: <201205220035.HHE05229.tFMJFOSOHOLFQV@I-love.SAKURA.ne.jp>
 <20120521182721.GB21406@tassilo.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au,
	akpm@linux-foundation.org
To: Andi Kleen <ak@linux.intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:36592 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751157Ab2EUSfT (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 21 May 2012 14:35:19 -0400
Content-Disposition: inline
In-Reply-To: <20120521182721.GB21406@tassilo.jf.intel.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, May 21, 2012 at 11:27:21AM -0700, Andi Kleen wrote:
> > diff --git a/fs/namespace.c b/fs/namespace.c
> > index 5a6208b..224aff1 100644
> > --- a/fs/namespace.c
> > +++ b/fs/namespace.c
> > @@ -2250,6 +2250,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns,
> >  		kfree(new_ns);
> >  		return ERR_PTR(-ENOMEM);
> >  	}
> > +	new_ns->root = new;
> 
> 
> oops. Thanks for finding that. Must have been a merge error somewhere.

Nah, just me cherry-picking unfixed variant.  It had come up back in March,
remember?  Replaced with fixed variant in the local tree, will go into
for-next (and for-linus, while we are at it) tonight or tomorrow morning.