From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: be more careful when returning
 -ENXIO in gmbus transfer
Date: Mon, 21 May 2012 21:04:56 +0200
Message-ID: <20120521190456.GF4970@phenom.ffwll.local>
References: <20120520181553.GE5145@phenom.ffwll.local>
	<1337624388-32498-1-git-send-email-daniel.vetter@ffwll.ch>
	<1337624682_164153@CP5-2952>
	<CAGS+omANiYtmKX_z2m2J-5j7a-K0z2MJ=wE3PcZRATmyh_VGxQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4AA6C9E77F
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 May 2012 12:03:38 -0700 (PDT)
Received: by wibhm14 with SMTP id hm14so2075346wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 May 2012 12:03:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAGS+omANiYtmKX_z2m2J-5j7a-K0z2MJ=wE3PcZRATmyh_VGxQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, May 21, 2012 at 11:31:20AM -0700, Daniel Kurtz wrote:
> On Mon, May 21, 2012 at 11:24 AM, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:
> > On Mon, 21 May 2012 20:19:48 +0200, Daniel Vetter <daniel.vetter@ffwll.=
ch> wrote:
> >> ... flaky ddc hardware can cause a spurious NAK, resulting in the i2c
> >> core and drm edid functions not trying to retry the edid transfer.
> >>
> >> Luckily the gmbus quiescenting also times out for these cases, so we
> >> can get out of this mess by returning -ETIMEDOUT for this specific
> >> case. This way we keep the fast-fail of returning -ENXIO if there is
> >> no device present, speeding up the boot process.
> >>
> >> This regression has been introduced in
> >>
> >> commit e646d5773572bf52017983d758bdf05777dc5600
> >> Author: Daniel Kurtz <djkurtz@chromium.org>
> >> Date: =A0 Fri Mar 30 19:46:38 2012 +0800
> >>
> >> =A0 =A0 drm/i915/intel_i2c: always wait for IDLE before clearing NAK
> >>
> >> v2: Return -ETIMEDOUT for this case and keep the -ENXIO for real NAKs,
> >> suggested by Daniel Kurtz.
> >>
> >> Cc: Daniel Kurtz <djkurtz@chromium.org>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D49518
> >> Reported-and-Tested-by: Julian Simioni <julian.simioni@gmail.com>
> >> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> > -Chris
> >
> > --
> > Chris Wilson, Intel Open Source Technology Centre
> =

> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Picked up for -fixes, thanks for the review.
-Daniel
-- =

Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48