From: Dimitri Sivanich <sivanich@sgi.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
Naga Chumbalkar <nagananda.chumbalkar@hp.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: check for valid irq_cfg pointer in smp_irq_move_cleanup_interrupt
Date: Mon, 21 May 2012 21:41:01 -0500 [thread overview]
Message-ID: <20120522024101.GA30298@sgi.com> (raw)
In-Reply-To: <1337634639.1997.148.camel@sbsiddha-desk.sc.intel.com>
On Mon, May 21, 2012 at 02:10:39PM -0700, Suresh Siddha wrote:
> On Mon, 2012-05-21 at 16:09 -0500, Dimitri Sivanich wrote:
> > On Mon, May 21, 2012 at 02:05:53PM -0700, Suresh Siddha wrote:
> > > On Mon, 2012-05-21 at 11:49 -0500, Dimitri Sivanich wrote:
> > > > The smp_irq_move_cleanup_interrupt routine should be checking for a valid
> > > > irq_cfg pointer prior to accessing it. It also seems that this should be
> > > > done after taking the desc lock.
> > >
> > > I think these changes are correct. Did you see any crashes during module
> > > unload etc?
> >
> > Yes, we have seen these on occasion during boot.
>
> During boot or shutdown?
>
Early on in boot, on rare occasions.
Easiest to reproduce doing module repeated module loads/unloads.
> Review of the code shows that this can trigger during module unload
> which can call destroy_irq() etc and can trigger the crash if there is a
> parallel irq migration related cleanup.
>
> Unsuccessful module loads can also call destroy_irq() but I doubt that
> is what happening here.
>
> thanks,
> suresh
>
next prev parent reply other threads:[~2012-05-22 2:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 16:49 [PATCH] x86: check for valid irq_cfg pointer in smp_irq_move_cleanup_interrupt Dimitri Sivanich
2012-05-21 21:05 ` Suresh Siddha
2012-05-21 21:09 ` Dimitri Sivanich
2012-05-21 21:10 ` Suresh Siddha
2012-05-22 2:41 ` Dimitri Sivanich [this message]
2012-05-21 21:07 ` Thomas Gleixner
2012-05-21 21:19 ` Dimitri Sivanich
2012-05-21 21:34 ` Thomas Gleixner
2012-05-23 18:16 ` Dimitri Sivanich
2012-05-23 19:04 ` Dimitri Sivanich
2012-05-23 19:24 ` Thomas Gleixner
2012-05-23 19:24 ` Suresh Siddha
2012-05-23 20:02 ` Dimitri Sivanich
2012-05-23 23:49 ` Suresh Siddha
2012-05-24 1:40 ` Dimitri Sivanich
2012-05-24 14:37 ` Dimitri Sivanich
2012-05-24 18:19 ` Suresh Siddha
2012-05-24 19:16 ` Thomas Gleixner
2012-05-26 0:23 ` Suresh Siddha
2012-05-26 10:18 ` Thomas Gleixner
2012-05-27 1:41 ` Jiang Liu
2012-05-30 13:46 ` Dimitri Sivanich
2012-05-24 14:53 ` Thomas Gleixner
2012-05-24 15:36 ` Dimitri Sivanich
-- strict thread matches above, loose matches on Subject: below --
2012-10-16 12:50 Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522024101.GA30298@sgi.com \
--to=sivanich@sgi.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nagananda.chumbalkar@hp.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.