From: Dan Carpenter <dan.carpenter@oracle.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, fmhess@users.sourceforge.net,
abbotti@mev.co.uk, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void __iomem *
Date: Tue, 22 May 2012 11:11:50 +0300 [thread overview]
Message-ID: <20120522081150.GE4637@mwanda> (raw)
In-Reply-To: <201205211810.07454.hartleys@visionengravers.com>
On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote:
> @@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev,
> if (ret < 0)
> return ret;
>
> - devpriv->ioaddr = (void *)(unsigned long)it->options[0];
> + devpriv->ioaddr = (void __iomem *)(unsigned long)it->options[0];
Obviously, your patch is fine, but I was wondering if it was a
problem that it->options was only a 32 bit? Seems like it would
deserve a comment.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-22 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 1:10 [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void __iomem * H Hartley Sweeten
2012-05-22 8:11 ` Dan Carpenter [this message]
2012-05-22 10:15 ` Ian Abbott
2012-06-05 3:22 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522081150.GE4637@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.