All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: santoshsy@gmail.com, vinholikatti@gmail.com,
	santosh.sy@samsung.com, James.Bottomley@HansenPartnership.com,
	jBottomley@parallels.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] ufs: fix potential NULL pointer dereferencing error in ufshcd_probe.
Date: Tue, 22 May 2012 13:15:35 -0700	[thread overview]
Message-ID: <20120522131535.22992314.akpm@linux-foundation.org> (raw)
In-Reply-To: <1337610936-2757-1-git-send-email-linkinjeon@gmail.com>

On Mon, 21 May 2012 10:35:36 -0400
Namjae Jeon <linkinjeon@gmail.com> wrote:

> Subject: [PATCH] [SCSI] ufs: fix potential NULL pointer dereferencing error in ufshcd_probe.

Nit: conventionally, the text inside [] is to be discarded by the patch
recipient, so the title of this patch is

	ufs: fix potential NULL pointer dereferencing error in ufshcd_probe.

which makes it look like a patch against fs/ufs/!

There is a fashion lately of people prefixing patch titles along the
lines of

  scsi: ufs: fix potential NULL pointer dereferencing error in ufshcd_probe.

or even

  drivers: scsi: ufs: fix potential NULL pointer dereferencing error in ufshcd_probe.

that's nuts, and I regularly turn this into a proper pathname - why
not?

  drivers/scsi/ufs: fix potential NULL pointer dereferencing error in ufshcd_probe.


I'll stop now :)

  reply	other threads:[~2012-05-22 20:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 14:35 [PATCH] [SCSI] ufs: fix potential NULL pointer dereferencing error in ufshcd_probe Namjae Jeon
2012-05-22 20:15 ` Andrew Morton [this message]
2012-05-22 23:03   ` Namjae Jeon
2012-05-23  8:52   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522131535.22992314.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jBottomley@parallels.com \
    --cc=linkinjeon@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=santosh.sy@samsung.com \
    --cc=santoshsy@gmail.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.