All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	John Stultz <john.stultz@linaro.org>,
	Shuah Khan <shuahkhan@gmail.com>,
	arve@android.com, Rebecca Schultz Zavin <rebecca@android.com>,
	Jesper Juhl <jj@chaosbits.net>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Thomas Meyer <thomas@m3y3r.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Marco Stornelli <marco.stornelli@gmail.com>,
	WANG Cong <xiyou.wangcong@gmail.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linaro-kernel@lists.linaro.org, patches@linaro.org,
	kernel-team@android.com
Subject: [PATCH v4 0/16] Merge ram_console into pstore, and more
Date: Tue, 22 May 2012 07:17:17 -0700	[thread overview]
Message-ID: <20120522141717.GA31574@lizard> (raw)

Hi all,

A brand new v4:

- Per Kees Cook's comments, the patches no longer remove an automatic
  updates feature, but instead make the it configurable; plus disable
  it by default (in a separate patch);
- Fixed some bugs noticed by Colin Cross;
- Documented new continuous ramoops-console log behaviour (also
  noticed by Colin Cross).

In v3:

- Rebased on top of current staging-next;
- The series are getting bigger. This is partly because we now support
  different persistent zone sizes for oops records and console log,
  per Colin Cross' request.
  And I believe the code is now more manageable for further enhancements
  (e.g. if we'd want to add other message types, e.g. tracing);
- Addressed Kees Cook's comments on the unlinking matters;
- Removed automatic updates support. Please see the last patch
  description for rationale;
- A new fixup for pstore/inode, just getting rid of a sparse warning.

In v2:

- Updated documentation per Colin Cross' comments;
- Corrected return value in ramoops_pstore_write() (noticed by Kees Cook);
- Fixed large writes handling in pstore_console_write(), i.e. when
  log_buf write is larger than pstore bufsize. Also Noticed by Kees Cook.


And a boilerplate for the series:

Currently pstore doesn't support logging kernel messages in run-time,
it only dumps dmesg when kernel oopses/panics. This makes pstore
useless for debugging hangs caused by HW issues or improper use of HW
(e.g. weird device inserted -> driver tried to write reserved bits ->
SoC hanged. In that case we don't get any messages in the pstore.

This series add a new message type for pstore, i.e. PSTORE_TYPE_CONSOLE,
plus make pstore/ram.c handle the new messages.

The old ram_console driver is removed. This might probably cause
some pain for out-of-tree code, as it would need to be adjusted...
but "no pain, no gain"? :-) Though, if there's some serious resistance,
we can probably postpone the last two patches.

Thanks!

--- 
 Documentation/ramoops.txt             |   14 ++
 drivers/staging/android/Kconfig       |    5 -
 drivers/staging/android/Makefile      |    1 -
 drivers/staging/android/ram_console.c |  179 --------------------------
 fs/pstore/Kconfig                     |    7 +
 fs/pstore/inode.c                     |    5 +-
 fs/pstore/platform.c                  |   49 ++++++-
 fs/pstore/ram.c                       |  228 ++++++++++++++++++++++++++-------
 fs/pstore/ram_core.c                  |  108 +++-------------
 include/linux/pstore.h                |    1 +
 include/linux/pstore_ram.h            |   22 +---
 11 files changed, 272 insertions(+), 347 deletions(-)

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

             reply	other threads:[~2012-05-22 14:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 14:17 Anton Vorontsov [this message]
2012-05-22 14:17 ` [PATCH 01/16] pstore/inode: Make pstore_fill_super() static Anton Vorontsov
2012-05-22 15:24   ` Kees Cook
2012-05-22 14:17 ` [PATCH 02/16] pstore/ram: Should update old dmesg buffer before reading Anton Vorontsov
2012-05-22 15:25   ` Kees Cook
2012-05-22 14:17 ` [PATCH 03/16] pstore/ram_core: Do not reset restored zone's position and size Anton Vorontsov
2012-05-22 18:06   ` Colin Cross
2012-05-23  2:35     ` [PATCH/RFC] Make sure linux_banner is the first message in log_buf Anton Vorontsov
2012-05-23  2:50       ` Linus Torvalds
2012-05-23  2:55       ` David Miller
2012-05-23  3:59         ` Anton Vorontsov
2012-05-22 14:17 ` [PATCH 04/16] pstore/ram_core: Factor persistent_ram_zap() out of post_init() Anton Vorontsov
2012-05-22 15:26   ` Kees Cook
2012-05-22 14:17 ` [PATCH 05/16] pstore/ram: Should zap persistent zone on unlink Anton Vorontsov
2012-05-22 15:27   ` Kees Cook
2012-05-22 14:17 ` [PATCH 06/16] pstore: Add console log messages support Anton Vorontsov
2012-05-22 14:17 ` [PATCH 07/16] pstore/ram: Introduce ramoops_context.max_dump_count Anton Vorontsov
2012-05-22 15:27   ` Kees Cook
2012-05-22 14:17 ` [PATCH 08/16] pstore/ram: Factor dmesg przs initialization out of probe() Anton Vorontsov
2012-05-22 15:29   ` Kees Cook
2012-05-22 14:17 ` [PATCH 09/16] pstore/ram: Factor ramoops_get_dump_prz() out of ramoops_pstore_read() Anton Vorontsov
2012-05-22 15:32   ` Kees Cook
2012-05-22 14:17 ` [PATCH 10/16] pstore/ram: Add console messages handling Anton Vorontsov
2012-05-22 15:37   ` Kees Cook
2012-05-22 14:17 ` [PATCH 11/16] pstore/ram_core: Silence some printks Anton Vorontsov
2012-05-22 14:17 ` [PATCH 12/16] pstore/ram: Add some more documentation and examples Anton Vorontsov
2012-05-22 14:17 ` [PATCH 13/16] staging/android: Remove ram_console driver Anton Vorontsov
2012-05-22 14:17 ` [PATCH 14/16] pstore/ram_core: Remove now unused code Anton Vorontsov
2012-05-22 14:17 ` [PATCH 15/16] pstore/platform: Make automatic updates interval configurable Anton Vorontsov
2012-05-22 15:39   ` Kees Cook
2012-05-22 14:17 ` [PATCH 16/16] pstore/platform: Disable automatic updates by default Anton Vorontsov
2012-05-22 15:42   ` Kees Cook
2012-05-22 18:19 ` [PATCH v4 0/16] Merge ram_console into pstore, and more Greg Kroah-Hartman
2012-05-22 18:33   ` Kees Cook
2012-05-22 19:04     ` Greg Kroah-Hartman
2012-05-22 19:09       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522141717.GA31574@lizard \
    --to=anton.vorontsov@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=arve@android.com \
    --cc=ccross@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jj@chaosbits.net \
    --cc=john.stultz@linaro.org \
    --cc=keescook@chromium.org \
    --cc=kernel-team@android.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.stornelli@gmail.com \
    --cc=patches@linaro.org \
    --cc=rdunlap@xenotime.net \
    --cc=rebecca@android.com \
    --cc=sboyd@codeaurora.org \
    --cc=shuahkhan@gmail.com \
    --cc=thomas@m3y3r.de \
    --cc=tony.luck@intel.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.