From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix PCH PLL assertions to not assume CRTC:PLL relationship Date: Tue, 22 May 2012 21:01:00 +0200 Message-ID: <20120522190100.GF4629@phenom.ffwll.local> References: <1337533850-5669-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 00F149E9E1 for ; Tue, 22 May 2012 11:59:44 -0700 (PDT) Received: by werc12 with SMTP id c12so5189973wer.36 for ; Tue, 22 May 2012 11:59:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1337533850-5669-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, May 20, 2012 at 06:10:50PM +0100, Chris Wilson wrote: > The existing assertions were written under the assumption that we wanted > to test the related PLL to a CRTC. With the split of PLL into a > separately managed entity which may be shared amongst CRTCs, we need to > pass in both the CRTC and the PLL to the assertion routine. > Occassionally, this means passing NULL for the CRTC as we wish to check > the status of the PLL irrespective of the current CRTC. > > Signed-off-by: Chris Wilson > Cc: Jesse Barnes Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48