From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Staging: ipack: fix failure registering an ipack device
Date: Wed, 23 May 2012 13:41:15 +0300 [thread overview]
Message-ID: <20120523104115.GL4637@mwanda> (raw)
In-Reply-To: <1337764395-23200-2-git-send-email-siglesias@igalia.com>
On Wed, May 23, 2012 at 11:13:14AM +0200, Samuel Iglesias Gonsalvez wrote:
> Trying to install an ipack device it always failed in the match() function. This
> patch fixes all the bugs present there.
>
This looks like part of it is undoing stuff introduced in
[patch 1/3]? I was going to ask what the stuff was in 1/3 and then
it got removed which makes me wonder why even more. Could you write
something about why in your changelog? Or if it's not needed then
remove it from the first patch.
Really it would be easier to review if you broke it up into one
patch per bug, with a description of what the bugs were instead of
"patch fixes all the bugs present there".
Some of these changes don't seem necessary. It feels like you were
debugging and then when you got match() to work you just committed
all the changes instead of only the lines which are needed.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-23 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 9:13 [PATCH 1/3] Staging: ipack/bridges/tpci200: delete sysfs files Samuel Iglesias Gonsalvez
2012-05-23 9:13 ` [PATCH 2/3] Staging: ipack: fix failure registering an ipack device Samuel Iglesias Gonsalvez
2012-05-23 10:41 ` Dan Carpenter [this message]
2012-05-23 10:42 ` Samuel Iglesias Gonsálvez
2012-05-23 9:13 ` [PATCH 3/3] Staging: ipack/bridges/tpci200: remove name field from slot_irq Samuel Iglesias Gonsalvez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523104115.GL4637@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.