From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Eric Miao <eric.y.miao@gmail.com>, Liam Girdwood <lrg@ti.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
alsa-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: fix pxa-ssp compiling issue under mach-mmp
Date: Wed, 23 May 2012 12:44:56 +0100 [thread overview]
Message-ID: <20120523114455.GA18646@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1337669906-12745-1-git-send-email-zhouqiao@marvell.com>
[-- Attachment #1.1: Type: text/plain, Size: 645 bytes --]
On Tue, May 22, 2012 at 02:58:26PM +0800, Qiao Zhou wrote:
> +#if defined(CONFIG_ARCH_PXA)
> if (cpu_is_pxa25x() && ssp->type == PXA25x_SSP) {
> sscr0 &= ~0x0000ff00;
> sscr0 |= ((div - 2)/2) << 8; /* 2..512 */
> } else {
> +#endif
> sscr0 &= ~0x000fff00;
> sscr0 |= (div - 1) << 8; /* 1..4096 */
> +#if defined(CONFIG_ARCH_PXA)
> }
> +#endif
This is pretty large and fiddly, especially code like the above. Would
it not be simpler to just define always false versions of these when on
MMP, either in this driver or in the arch headers (where it'd help other
drivers too)? Right now it doesn't make the code look nice.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-05-23 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1337669906-12745-1-git-send-email-zhouqiao@marvell.com>
2012-05-22 7:05 ` [PATCH 2/2] ASoC: fix pxa-ssp compiling issue under mach-mmp Haojian Zhuang
2012-05-23 11:44 ` Mark Brown [this message]
[not found] <1338443313-28276-1-git-send-email-zhouqiao@marvell.com>
2012-06-01 12:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523114455.GA18646@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=haojian.zhuang@gmail.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.