From: Gleb Natapov <gleb@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.
Date: Wed, 23 May 2012 15:47:57 +0300 [thread overview]
Message-ID: <20120523124757.GG10209@redhat.com> (raw)
In-Reply-To: <CAFEAcA-QAtdv-0MufTbux8LmpDF23e9=4LaVGd0vAKyXHnJXQw@mail.gmail.com>
On Wed, May 23, 2012 at 01:44:45PM +0100, Peter Maydell wrote:
> On 20 May 2012 10:02, Gleb Natapov <gleb@redhat.com> wrote:
> > There can be only one fw_cfg device, so saving global reference to it
> > removes the need to pass its pointer around.
>
> This seems like a backwards step to me: one of the things that prevents
> us supporting "two separate machines in one emulation" is that we have
> various things that assume there's only one instance of themselves and
> use globals. I don't think we should be adding any more...
>
So you do it usual way. Have "struct Machine" and put pointer to fw_cfg
there. Current code already saves global pointer to fw_cfg, the patch just
makes it official.
--
Gleb.
next prev parent reply other threads:[~2012-05-23 12:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 9:02 [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global Gleb Natapov
2012-05-20 9:02 ` [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states Gleb Natapov
2012-05-23 13:27 ` Anthony Liguori
2012-05-23 13:34 ` Gleb Natapov
2012-05-23 13:48 ` Anthony Liguori
2012-05-23 14:34 ` Andreas Färber
2012-05-23 14:42 ` Paolo Bonzini
2012-05-23 15:11 ` Anthony Liguori
2012-05-23 15:16 ` Gleb Natapov
2012-05-23 12:37 ` [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global Gleb Natapov
2012-05-23 13:25 ` Anthony Liguori
2012-05-23 13:32 ` Gleb Natapov
2012-05-23 13:46 ` Anthony Liguori
2012-05-23 12:44 ` Peter Maydell
2012-05-23 12:47 ` Gleb Natapov [this message]
2012-05-23 14:41 ` Andreas Färber
2012-05-23 14:54 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2012-05-14 12:34 Gleb Natapov
2012-05-14 18:53 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523124757.GG10209@redhat.com \
--to=gleb@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.