From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] Staging: ipack/bridges/tpci200: tpci200_slot_unmap_space() should return 0 if succeed.
Date: Wed, 23 May 2012 17:25:03 +0300 [thread overview]
Message-ID: <20120523142503.GM4629@mwanda> (raw)
In-Reply-To: <1337781287-28628-4-git-send-email-siglesias@igalia.com>
On Wed, May 23, 2012 at 03:54:42PM +0200, Samuel Iglesias Gonsalvez wrote:
> tpci200_slot_unmap_space() should return 0 if the operation was properly done. If
> not, the caller will think that something wrong happened.
>
It's weird and frustrating that gcc didn't warn that we used "res"
without initializing it. It feels like the goto out_unlock places
should return an error. But actually the callers don't don't check
the return values so I guess it doesn't matter.
All these patches look good.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-23 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 13:54 [PATCH 0/8] fix errors in the match process Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 1/8] Staging ipack/bridges/tpci200: delete sysfs files Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 2/8] Staging: ipack: return proper value in match() function Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 3/8] Staging: ipack/bridges/tpci200: tpci200_slot_unmap_space() should return 0 if succeed Samuel Iglesias Gonsalvez
2012-05-23 14:25 ` Dan Carpenter [this message]
2012-05-23 13:54 ` [PATCH 4/8] Staging: ipack/bridges/tpci200: tpci200_slot_map_space() " Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 5/8] Staging: ipack/bridges/tpci200: check if the remove function is available Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 6/8] Staging: ipack/bridges/tpci200: fix indention Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 7/8] Staging: ipack/bridges/tpci200: remove name field from slot_irq Samuel Iglesias Gonsalvez
2012-05-23 13:54 ` [PATCH 8/8] Staging ipack/bridges/tpci200: removed check of tpci200->slots[dev->slot].dev Samuel Iglesias Gonsalvez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523142503.GM4629@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.