From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Mikel Astiz <mikel.astiz.oss@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: Re: [PATCH obexd v0 03/16] client: Add progress property to transfer
Date: Wed, 23 May 2012 14:40:16 -0300 [thread overview]
Message-ID: <20120523174016.GA32263@samus> (raw)
In-Reply-To: <1337785218-8661-4-git-send-email-mikel.astiz.oss@gmail.com>
Hi Mikel,
On 17:00 Wed 23 May, Mikel Astiz wrote:
> From: Mikel Astiz <mikel.astiz@bmw-carit.de>
>
> The number of transferred bytes is exposed in D-Bus using a specific
> property for this purpose.
>
> Internally, the value of this property does not necessarily match the
> internal progress counter. In order to avoid D-Bus overhead, the
> property will be updated at least every N bytes, where N is fixed and
> hardcoded (TRANSFER_PROGRESS_PERIOD).
> ---
> client/transfer.c | 47 +++++++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 45 insertions(+), 2 deletions(-)
>
> diff --git a/client/transfer.c b/client/transfer.c
> index 8292265..2c6e1ed 100644
> --- a/client/transfer.c
> +++ b/client/transfer.c
> @@ -44,6 +44,7 @@
>
> #define TRANSFER_INTERFACE "org.openobex.Transfer"
> #define TRANSFER_BASEPATH "/org/openobex"
> +#define TRANSFER_PROGRESS_PERIOD (16 * 1024)
Just a detail, but this value is half the value of the default Bluetooth
MTU, right?
For a future improvement, I think it would be nice to consider a value
related to the MTU.
[snip]
>
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
--
Vinicius
next prev parent reply other threads:[~2012-05-23 17:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 15:00 [PATCH obexd v0 00/16] client: Remove D-Bus agent Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 01/16] client: Add D-Bus helper library Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 02/16] client-doc: Add progress property to transfer Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 03/16] client: " Mikel Astiz
2012-05-23 17:40 ` Vinicius Costa Gomes [this message]
2012-05-24 8:25 ` Luiz Augusto von Dentz
2012-05-24 14:42 ` Vinicius Costa Gomes
2012-05-23 15:00 ` [PATCH obexd v0 04/16] client-doc: Add transfer event-reporting signals Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 05/16] client: " Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 06/16] client-doc: Remove D-Bus agent Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 07/16] client: Use transfer owner instead of agent Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 08/16] client: Remove D-Bus agent Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 09/16] client: Remove unused functions in transfer API Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 10/16] client: Remove internal transfer progress report Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 11/16] client: Remove obsolete authentication code Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 12/16] client: Make D-Bus exposure of transfers optional Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 13/16] client-doc: Add signal to report new transfers Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 14/16] client: Expose D-Bus data in internal transfer API Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 15/16] client: Add signal to report new transfers Mikel Astiz
2012-05-23 15:00 ` [PATCH obexd v0 16/16] client-test: Remove agent from ftp-client Mikel Astiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523174016.GA32263@samus \
--to=vinicius.gomes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz.oss@gmail.com \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.