From: Alessandro Rubini <rubini@gnudd.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: RFC: amba: remove NO_IRQ
Date: Thu, 24 May 2012 11:19:33 +0200 [thread overview]
Message-ID: <20120524091933.GA8566@mail.gnudd.com> (raw)
I'm using PrimeCell devices under PCIe, x86 platform. We discussed
this issue on Mar 1st, and you (Russell) reported that NO_IRQ is
expected to go away for ARM, as 0 is the new official "no irq" marker.
The trivial patch below is what I'm currently using to compile my
stuff, but I'd like to get an update about NO_IRQ in ARM (which you
complained was completely on your shoulders). If needed I can take it
over and propose patches.
I'm well aware that the few users within arch/arm are matched by a
much bigger number of users in drivers/ . The work is not trivial,
but at least I hope to be able to remove NO_IRQ from amba/bus.c by
auditing all its users.
thanks
/alessandro
---
drivers/amba/bus.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index 64ddedd..490a308 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -546,10 +546,10 @@ int amba_device_add(struct amba_device *dev, struct resource *parent)
goto err_release;
printk(KERN_INFO "%s %i\n", __func__, __LINE__);
- if (dev->irq[0] && dev->irq[0] != NO_IRQ)
+ if (dev->irq[0])
ret = device_create_file(&dev->dev, &dev_attr_irq0);
printk(KERN_INFO "%s %i\n", __func__, __LINE__);
- if (ret == 0 && dev->irq[1] && dev->irq[1] != NO_IRQ)
+ if (ret == 0 && dev->irq[1])
ret = device_create_file(&dev->dev, &dev_attr_irq1);
printk(KERN_INFO "%s %i\n", __func__, __LINE__);
if (ret == 0)
--
1.7.7.2
next reply other threads:[~2012-05-24 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 9:19 Alessandro Rubini [this message]
2012-05-24 9:24 ` RFC: amba: remove NO_IRQ Russell King - ARM Linux
2012-05-24 9:37 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524091933.GA8566@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.