All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] OMAP5: EMIF: Add support for DDR3 device
Date: Thu, 24 May 2012 06:46:59 -0700	[thread overview]
Message-ID: <20120524134659.GA14346@bill-the-cat> (raw)
In-Reply-To: <CAJ7qFSf4DOQ7xJ8uS9yMUu_9kSWR-WH-3cXYCw3n+wsB84xn9Q@mail.gmail.com>

On Thu, May 24, 2012 at 12:15:23PM +0530, R, Sricharan wrote:
> Hi Tom,
[snip]
> > ?I'm going to try and locally make the ddr3 patches work on the am33xx DDR3
> > board as a way to prove that out and if it works, and we're fine with what
> > I've laid out above, start working towards that layout.
> >
>  yeah, sounds correct.
>   How about something like this, similar to the above
> #define DDR2 1
> #define LPDDR2 2
> #define DDR3 3
> #define LPDDR3 4
> 
> and soc specific code returns the correct ddr type. For OMAP
> get_ddr_type()
> {
>  switch(EMIF_SDRAM_CONFIG & SDRAM_TYPE) {
>  case 3:
>      return DDR3;
>  case 4:
>  case 5:
>  default:
>     return LPDDR2;
> }
> We can avoid the #ifdef s in the emif code and use the type returned by
> SOC to do the required initialisations. ?

One thing I want to avoid is bloating each of the boards with DDR config
code it won't ever use.  OMAP4/5 won't have DDR2 and AM33xx won't have
LPDDR2.  But maybe there's some linker magic we can do to avoid #ifdefs.

-- 
Tom

  reply	other threads:[~2012-05-24 13:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 10:03 [U-Boot] [PATCH 0/7] OMAP5: Add support for OMAP5432 SOC Lokesh Vutla
2012-05-22 10:03 ` [U-Boot] [PATCH 1/7] OMAP5: Adding correct Control id code for OMAP5430 Lokesh Vutla
2012-05-22 10:24   ` R, Sricharan
2012-05-22 10:03 ` [U-Boot] [PATCH 2/7] OMAP5: ADD chip detection for OMAP5432 SOC Lokesh Vutla
2012-05-22 10:03 ` [U-Boot] [PATCH 3/7] OMAP5: Configure the io settings for omap5432 uevm board Lokesh Vutla
2012-05-22 10:03 ` [U-Boot] [PATCH 4/7] OMAP5: ADD precalculated timings for ddr3 Lokesh Vutla
2012-05-22 10:31   ` R, Sricharan
2012-05-22 10:03 ` [U-Boot] [PATCH 5/7] OMAP5: EMIF: Add support for DDR3 device Lokesh Vutla
2012-05-22 14:41   ` Tom Rini
2012-05-22 14:58     ` R, Sricharan
2012-05-22 15:18       ` Tom Rini
2012-05-22 15:27         ` R, Sricharan
2012-05-22 15:39           ` Tom Rini
2012-05-23 12:22             ` R, Sricharan
2012-05-23 16:55               ` Tom Rini
2012-05-24  6:45                 ` R, Sricharan
2012-05-24 13:46                   ` Tom Rini [this message]
2012-05-22 10:03 ` [U-Boot] [PATCH 6/7] OMAP5: DPLL core lock for OMAP5432 Lokesh Vutla
2012-05-22 10:36   ` R, Sricharan
2012-05-22 10:03 ` [U-Boot] [PATCH 7/7] OMAP5: Change voltages for omap5432 Lokesh Vutla
2012-05-25 15:04 ` [U-Boot] [PATCH 0/7] OMAP5: Add support for OMAP5432 SOC Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524134659.GA14346@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.