From: NeilBrown <neilb@suse.de>
To: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org, axboe@kernel.dk, shli@fusionio.com
Subject: Re: [patch 1/4] raid1: directly dispatch write request if no bitmap
Date: Thu, 24 May 2012 13:51:17 +1000 [thread overview]
Message-ID: <20120524135117.238b2ed9@notabene.brown> (raw)
In-Reply-To: <20120524033126.GA1172@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Thu, 24 May 2012 11:31:26 +0800 Shaohua Li <shli@kernel.org> wrote:
> On Thu, May 24, 2012 at 01:09:12PM +1000, NeilBrown wrote:
> > Not necessarily. It might queue it:
> > if (current->bio_list) {
> > bio_list_add(current->bio_list, bio);
> > return;
> > }
>
> Ah, yes. Looks we can workaround it to increase bioset entry number to
> raid_disks*2. There isn't too much memory wasted with it.
No, that doesn't work. There might be raid_disk*2 separate threads which
have each allocated on entry from the pool, and then they all block waiting
for another.
Adding the pool can change the probability of a deadlock but not the
possibility.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-05-24 3:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 7:26 [patch 0/4] MD: improve raid1/10 write performance for fast storage Shaohua Li
2012-05-23 7:26 ` [patch 1/4] raid1: directly dispatch write request if no bitmap Shaohua Li
2012-05-24 2:21 ` NeilBrown
2012-05-24 2:54 ` Shaohua Li
2012-05-24 3:09 ` NeilBrown
2012-05-24 3:31 ` Shaohua Li
2012-05-24 3:51 ` NeilBrown [this message]
2012-05-23 7:26 ` [patch 2/4] raid1: percpu dispatch for write request if bitmap supported Shaohua Li
2012-05-24 3:34 ` NeilBrown
2012-05-24 5:17 ` Shaohua Li
2012-05-24 5:34 ` NeilBrown
2012-05-24 5:50 ` Shaohua Li
2012-05-23 7:26 ` [patch 3/4] raid10: directly dispatch write request if no bitmap Shaohua Li
2012-05-23 7:26 ` [patch 4/4] raid10: percpu dispatch for write request if bitmap supported Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524135117.238b2ed9@notabene.brown \
--to=neilb@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fusionio.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.