From: Gustavo Padovan <gustavo@padovan.org>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>,
linux-bluetooth@vger.kernel.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [RFC 1/2] Bluetooth: Create chan->ops->set_err()
Date: Thu, 24 May 2012 14:04:12 -0300 [thread overview]
Message-ID: <20120524170412.GE3105@joana> (raw)
In-Reply-To: <20120524082603.GE24715@aemeltch-MOBL1>
Hi Andrei,
* Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com> [2012-05-24 11:26:04 +0300]:
> Hi Gustavo,
>
> On Thu, May 24, 2012 at 04:00:16AM -0300, Gustavo Padovan wrote:
> > - lock_sock(sk);
> > - __l2cap_state_change(chan, BT_DISCONN);
> > - __l2cap_chan_set_err(chan, err);
> > - release_sock(sk);
> > + l2cap_state_change(chan, BT_DISCONN);
> > + if(chan->ops->set_err)
> > + chan->ops->set_err(chan->data, err);
>
> I do not know can it be done somehow better, currently we lock and unlock
> sockets for each operation.
I'm having trouble to get your point, could you please explain?
Gustavo
next prev parent reply other threads:[~2012-05-24 17:04 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 1:12 [RFC 0/8] Another step in l2cap_core/sock separation Gustavo Padovan
2012-05-24 1:12 ` [RFC 1/8] Bluetooth: Move clean up code and set of SOCK_ZAPPED to l2cap_sock.c Gustavo Padovan
2012-05-24 1:12 ` [RFC 2/8] Bluetooth: Remove extra l2cap_state_change(BT_CONNECTED) Gustavo Padovan
2012-05-24 1:12 ` [RFC 3/8] Bluetooth: Add l2cap_chan->ops->ready() Gustavo Padovan
2012-05-24 1:12 ` [RFC 4/8] Bluetooth: Use l2cap_chan_ready() in LE path Gustavo Padovan
2012-05-24 1:12 ` [RFC 5/8] Bluetooth: Use chan->state instead of sk->sk_state Gustavo Padovan
2012-05-24 1:12 ` [RFC 6/8] Bluetooth: Move check for backlog size to l2cap_sock.c Gustavo Padovan
2012-05-24 1:12 ` [RFC 7/8] Bluetooth: Create DEFER_SETUP flag in conf_state Gustavo Padovan
2012-05-24 1:12 ` [RFC 8/8] Bluetooth: Add chan->ops->authorize Gustavo Padovan
2012-05-24 6:02 ` [RFC 1/3] Bluetooth: check for already existent channel before create new one Gustavo Padovan
2012-05-24 6:02 ` [RFC 2/3] Bluetooth: Move bt_accept_enqueue() call to l2cap_sock.c Gustavo Padovan
2012-05-24 6:02 ` [RFC 3/3] Blueooth: Remove parent socket usage from l2cap_core.c Gustavo Padovan
2012-05-24 6:32 ` Gustavo Padovan
2012-05-24 7:00 ` [RFC 1/2] Bluetooth: Create chan->ops->set_err() Gustavo Padovan
2012-05-24 7:00 ` [RFC 2/2] Bluetooth: Remove last usage of sk->sk_state_change() Gustavo Padovan
2012-05-24 8:30 ` Andrei Emeltchenko
2012-05-24 17:06 ` Gustavo Padovan
2012-05-24 8:26 ` [RFC 1/2] Bluetooth: Create chan->ops->set_err() Andrei Emeltchenko
2012-05-24 17:04 ` Gustavo Padovan [this message]
2012-05-24 17:18 ` Mat Martineau
2012-05-25 7:07 ` Andrei Emeltchenko
2012-05-24 9:22 ` [RFC 3/3] Blueooth: Remove parent socket usage from l2cap_core.c Andrei Emeltchenko
2012-05-24 9:24 ` [RFC 2/3] Bluetooth: Move bt_accept_enqueue() call to l2cap_sock.c Andrei Emeltchenko
2012-05-24 17:09 ` Gustavo Padovan
2012-05-24 17:36 ` Mat Martineau
2012-05-24 9:27 ` [RFC 1/3] Bluetooth: check for already existent channel before create new one Andrei Emeltchenko
2012-05-24 9:55 ` [RFC 8/8] Bluetooth: Add chan->ops->authorize Andrei Emeltchenko
2012-05-24 17:08 ` Gustavo Padovan
2012-05-24 17:10 ` Mat Martineau
2012-05-24 9:50 ` [RFC 7/8] Bluetooth: Create DEFER_SETUP flag in conf_state Andrei Emeltchenko
2012-05-24 17:01 ` Gustavo Padovan
2012-05-24 9:45 ` [RFC 6/8] Bluetooth: Move check for backlog size to l2cap_sock.c Andrei Emeltchenko
2012-05-24 16:57 ` Gustavo Padovan
2012-05-24 9:39 ` [RFC 3/8] Bluetooth: Add l2cap_chan->ops->ready() Andrei Emeltchenko
2012-05-24 10:23 ` Andrei Emeltchenko
2012-05-24 11:17 ` Ulisses Furquim
2012-05-24 11:30 ` Andrei Emeltchenko
2012-05-24 11:31 ` Ulisses Furquim
2012-05-24 11:37 ` Andrei Emeltchenko
2012-05-24 17:48 ` Mat Martineau
2012-05-24 17:53 ` Ulisses Furquim
2012-05-24 18:48 ` Vinicius Costa Gomes
2012-05-24 9:38 ` [RFC 2/8] Bluetooth: Remove extra l2cap_state_change(BT_CONNECTED) Andrei Emeltchenko
2012-05-24 9:35 ` [RFC 1/8] Bluetooth: Move clean up code and set of SOCK_ZAPPED to l2cap_sock.c Andrei Emeltchenko
2012-05-24 16:56 ` Gustavo Padovan
2012-05-24 17:14 ` Gustavo Padovan
2012-05-24 17:25 ` Vinicius Costa Gomes
2012-05-24 6:12 ` [RFC 0/8] Another step in l2cap_core/sock separation Gustavo Padovan
2012-05-24 10:02 ` Andrei Emeltchenko
2012-05-24 16:43 ` Gustavo Padovan
2012-05-24 17:55 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524170412.GE3105@joana \
--to=gustavo@padovan.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.