From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexey Galakhov <agalakhov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] S5P DRAM support
Date: Thu, 24 May 2012 22:13:44 +0200 [thread overview]
Message-ID: <20120524201344.GD30400@pengutronix.de> (raw)
In-Reply-To: <1337866065-6775-2-git-send-email-agalakhov@gmail.com>
On Thu, May 24, 2012 at 07:27:44PM +0600, Alexey Galakhov wrote:
> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
> ---
> arch/arm/mach-samsung/Makefile | 2 +-
> arch/arm/mach-samsung/include/mach/s3c-generic.h | 6 +
> arch/arm/mach-samsung/include/mach/s5pcxx-iomap.h | 3 +
> arch/arm/mach-samsung/mem-s5pcxx.c | 319 +++++++++++++++++++++
> 4 files changed, 329 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/mach-samsung/mem-s5pcxx.c
>
> +
> +static void __bare_init s5p_dram_init_seq_lpddr(phys_addr_t base, unsigned chip)
> +{
> + const uint32_t emr = 0x400; /* DQS disable */
> + const uint32_t mr = (((S5P_DRAM_WR) - 1) << 9)
> + | ((S5P_DRAM_CAS) << 4)
> + | (S5P_DRAM_BURST);
> + /* FIXME this sequence is untested */
Maybe add these comments to the exported functions rather than in the
helpers? It would be more prominent and people would see it more easily.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-24 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 13:27 [RFC:PATCH 0/2] Revised S5PV210 DRAM support Alexey Galakhov
2012-05-24 13:27 ` [PATCH 1/2] S5P " Alexey Galakhov
2012-05-24 20:13 ` Sascha Hauer [this message]
2012-05-24 13:27 ` [PATCH 2/2] Add FriendlyArm Tiny210 board (S5PV210) Alexey Galakhov
2012-05-24 20:11 ` Sascha Hauer
2012-05-28 9:38 ` Alexey Galakhov
-- strict thread matches above, loose matches on Subject: below --
2012-07-02 15:53 [PATCH 0/2] Very minimal support S5PV210 board (Tiny210) Alexey Galakhov
2012-07-02 15:53 ` [PATCH 1/2] S5P DRAM support Alexey Galakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524201344.GD30400@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=agalakhov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.