From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, Len Brown <lenb@kernel.org>,
Wei Kong <wkong@novell.com>, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH] PCI / ACPI: Do not request control of ASPM if the BIOS has disabled it
Date: Thu, 24 May 2012 21:45:38 +0100 [thread overview]
Message-ID: <20120524204538.GA27819@srcf.ucam.org> (raw)
In-Reply-To: <201205242245.45888.rjw@sisk.pl>
On Thu, May 24, 2012 at 10:45:45PM +0200, Rafael J. Wysocki wrote:
> However, knowing that the BIOS doesn't support ASPM, we shouldn't
> request the control of it, so we should remove
> (OSC_ACTIVE_STATE_PWR_SUPPORT | OSC_CLOCK_PWR_CAPABILITY_SUPPORT)
> from the flags before calling acpi_pci_osc_control_set() in those
> cases. Failing to do so causes the evaluation of _OSC for the PCI
> root bridge to return error codes on some systems where it should
> work correctly.
Is there an example of an affected machine's DSDT?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-05-24 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 20:45 [PATCH] PCI / ACPI: Do not request control of ASPM if the BIOS has disabled it Rafael J. Wysocki
2012-05-24 20:45 ` Matthew Garrett [this message]
2012-05-25 11:53 ` Jean Delvare
2012-08-15 19:47 ` Bjorn Helgaas
2012-08-15 20:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524204538.GA27819@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bhelgaas@google.com \
--cc=jdelvare@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=wkong@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.