From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [git pull] Input updates for 3.5-rc0
Date: Fri, 25 May 2012 07:01:05 +0900 [thread overview]
Message-ID: <20120524220105.GB18120@kroah.com> (raw)
In-Reply-To: <CA+55aFzZm2aAhgZagWq=rsfKTt=2_2_mpVjXDN3LAqAJmWoZqw@mail.gmail.com>
On Thu, May 24, 2012 at 02:44:31PM -0700, Linus Torvalds wrote:
> On Thu, May 24, 2012 at 2:07 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > On Thu, May 24, 2012 at 1:59 PM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> >>
> >> I was concerned about the _next_ device (the one that will be created
> >> the moment I plug in the tablet back into the same port) having exact
> >> same name as the one that is half dead and clashing in sysfs and
> >> elsewhere. We used to have issues with this.
> >
> > Ok, that's certainly a valid concern.
> >
> > It's still - I think - really sad/wrong that the device name is then
> > so useless than the drivers end up basically not using it.
>
> Ok, so I wonder if we could solve the issue at least partly by
> separating the "print name for kernel messages" from the "name used
> for /sysfs etc".
>
> Because you're right: the sysfs uniqueness rules does make it very
> hard to do a good job on descriptive names.
>
> Also, in sysfs, you by definition see the parent (hey, it's part of
> the path), so in sysfs, duplicating parent data would be useless and
> just ugly.
>
> But for dev_dbg(), those sysfs rules actually act against us: the name
> of a device is often tied to the parent bus location.
>
> So I wonder if we could teach dev_printk() to use something more
> interesting than "dev_name()" when appropriate? Greg?
I'm open to ideas on what to change it to. A full sysfs path?
Something more "unique"? I don't know what works for everything here.
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-24 22:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 8:32 [git pull] Input updates for 3.5-rc0 Dmitry Torokhov
2012-05-24 17:33 ` Linus Torvalds
2012-05-24 18:01 ` Dmitry Torokhov
2012-05-24 18:21 ` Linus Torvalds
2012-05-24 19:58 ` Dmitry Torokhov
2012-05-24 20:11 ` Linus Torvalds
2012-05-24 20:11 ` Linus Torvalds
2012-05-24 20:36 ` Dmitry Torokhov
2012-05-24 20:36 ` Dmitry Torokhov
2012-05-24 20:48 ` Linus Torvalds
2012-05-24 20:59 ` Dmitry Torokhov
2012-05-24 21:07 ` Linus Torvalds
2012-05-24 21:38 ` Dmitry Torokhov
2012-05-24 21:56 ` Linus Torvalds
2012-05-24 21:44 ` Linus Torvalds
2012-05-24 21:56 ` Dmitry Torokhov
2012-05-24 21:59 ` Linus Torvalds
2012-05-24 21:59 ` Linus Torvalds
2012-05-24 22:01 ` Greg Kroah-Hartman [this message]
2012-05-24 22:05 ` Linus Torvalds
2012-05-24 22:05 ` Linus Torvalds
2012-05-25 1:39 ` Greg Kroah-Hartman
2012-05-25 19:05 ` Mark Lord
2012-05-24 21:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524220105.GB18120@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.