From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH v2 04/14] block: Add bio_clone_kmalloc() Date: Thu, 24 May 2012 17:31:14 -0700 Message-ID: <20120525003114.GF22664@google.com> References: <1337817771-25038-1-git-send-email-koverstreet@google.com> <1337817771-25038-5-git-send-email-koverstreet@google.com> <20120524185919.GE27550@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120524185919.GE27550-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vivek Goyal Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org, mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org, yehuda-L5o5AL9CYN0tUFlbccrkMA@public.gmane.org List-Id: dm-devel.ids On Thu, May 24, 2012 at 02:59:19PM -0400, Vivek Goyal wrote: > On Wed, May 23, 2012 at 05:02:41PM -0700, Kent Overstreet wrote: > > [..] > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > > index 013c7a5..5a953c6 100644 > > --- a/drivers/block/rbd.c > > +++ b/drivers/block/rbd.c > > @@ -729,7 +729,7 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next, > > } > > > > while (old_chain && (total < len)) { > > - tmp = bio_kmalloc(gfpmask, old_chain->bi_max_vecs); > > + tmp = bio_clone_kmalloc(old_chain, gfpmask); > > if (!tmp) > > goto err_out; > > > > @@ -751,13 +751,9 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next, > > if (!bp) > > goto err_out; > > > > - __bio_clone(tmp, &bp->bio1); > > - > > *next = &bp->bio2; > > Is this code correct. Now original code might clone bio after split and > new code will clone the original bio itself and not the split one? Argh, you're right, I screwed that up. I'd like to get rid of all the open coded bio_clone()s out there (to reduce the amount of code that "Only clone bio vecs that are in use" has to change, but this code is too tricky - I'm just going to drop this bit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.linbit.com (zimbra.linbit.com [212.69.161.123]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 2B1751011C0C for ; Fri, 25 May 2012 09:04:08 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.linbit.com (Postfix) with ESMTP id 20A311B4262 for ; Fri, 25 May 2012 09:04:08 +0200 (CEST) Received: from zimbra.linbit.com ([127.0.0.1]) by localhost (zimbra.linbit.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X85UxheSg1W2 for ; Fri, 25 May 2012 09:04:08 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra.linbit.com (Postfix) with ESMTP id 001121B4206 for ; Fri, 25 May 2012 09:04:07 +0200 (CEST) Resent-Message-ID: <20120525070407.GQ12726@soda.linbit> Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id DB085106DCC0 for ; Fri, 25 May 2012 02:31:19 +0200 (CEST) Received: by pbbro2 with SMTP id ro2so1300999pbb.27 for ; Thu, 24 May 2012 17:31:17 -0700 (PDT) Date: Thu, 24 May 2012 17:31:14 -0700 From: Kent Overstreet To: Vivek Goyal Message-ID: <20120525003114.GF22664@google.com> References: <1337817771-25038-1-git-send-email-koverstreet@google.com> <1337817771-25038-5-git-send-email-koverstreet@google.com> <20120524185919.GE27550@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120524185919.GE27550@redhat.com> Cc: axboe@kernel.dk, yehuda@hq.newdream.net, dm-devel@redhat.com, neilb@suse.de, linux-kernel@vger.kernel.org, tj@kernel.org, linux-bcache@vger.kernel.org, mpatocka@redhat.com, bharrosh@panasas.com, linux-fsdevel@vger.kernel.org, sage@newdream.net, agk@redhat.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH v2 04/14] block: Add bio_clone_kmalloc() List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 24, 2012 at 02:59:19PM -0400, Vivek Goyal wrote: > On Wed, May 23, 2012 at 05:02:41PM -0700, Kent Overstreet wrote: > > [..] > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > > index 013c7a5..5a953c6 100644 > > --- a/drivers/block/rbd.c > > +++ b/drivers/block/rbd.c > > @@ -729,7 +729,7 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next, > > } > > > > while (old_chain && (total < len)) { > > - tmp = bio_kmalloc(gfpmask, old_chain->bi_max_vecs); > > + tmp = bio_clone_kmalloc(old_chain, gfpmask); > > if (!tmp) > > goto err_out; > > > > @@ -751,13 +751,9 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next, > > if (!bp) > > goto err_out; > > > > - __bio_clone(tmp, &bp->bio1); > > - > > *next = &bp->bio2; > > Is this code correct. Now original code might clone bio after split and > new code will clone the original bio itself and not the split one? Argh, you're right, I screwed that up. I'd like to get rid of all the open coded bio_clone()s out there (to reduce the amount of code that "Only clone bio vecs that are in use" has to change, but this code is too tricky - I'm just going to drop this bit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964820Ab2EYAbU (ORCPT ); Thu, 24 May 2012 20:31:20 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:51869 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759425Ab2EYAbR (ORCPT ); Thu, 24 May 2012 20:31:17 -0400 Date: Thu, 24 May 2012 17:31:14 -0700 From: Kent Overstreet To: Vivek Goyal Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, tj@kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de, drbd-dev@lists.linbit.com, bharrosh@panasas.com, mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net Subject: Re: [PATCH v2 04/14] block: Add bio_clone_kmalloc() Message-ID: <20120525003114.GF22664@google.com> References: <1337817771-25038-1-git-send-email-koverstreet@google.com> <1337817771-25038-5-git-send-email-koverstreet@google.com> <20120524185919.GE27550@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120524185919.GE27550@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 24, 2012 at 02:59:19PM -0400, Vivek Goyal wrote: > On Wed, May 23, 2012 at 05:02:41PM -0700, Kent Overstreet wrote: > > [..] > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > > index 013c7a5..5a953c6 100644 > > --- a/drivers/block/rbd.c > > +++ b/drivers/block/rbd.c > > @@ -729,7 +729,7 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next, > > } > > > > while (old_chain && (total < len)) { > > - tmp = bio_kmalloc(gfpmask, old_chain->bi_max_vecs); > > + tmp = bio_clone_kmalloc(old_chain, gfpmask); > > if (!tmp) > > goto err_out; > > > > @@ -751,13 +751,9 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next, > > if (!bp) > > goto err_out; > > > > - __bio_clone(tmp, &bp->bio1); > > - > > *next = &bp->bio2; > > Is this code correct. Now original code might clone bio after split and > new code will clone the original bio itself and not the split one? Argh, you're right, I screwed that up. I'd like to get rid of all the open coded bio_clone()s out there (to reduce the amount of code that "Only clone bio vecs that are in use" has to change, but this code is too tricky - I'm just going to drop this bit.