All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen: add bridge check
Date: Thu, 24 May 2012 22:28:18 -0400	[thread overview]
Message-ID: <20120525022818.GB27126@phenom.dumpdata.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E15587E@SHSMSX101.ccr.corp.intel.com>

On Fri, May 25, 2012 at 02:05:17AM +0000, Zhang, Yang Z wrote:
> Hi konrad,
> Any comments with this patch?

Looks good. applied.

> 
> best regards
> yang
> 
> > -----Original Message-----
> > From: Zhang, Yang Z
> > Sent: Tuesday, May 22, 2012 4:40 PM
> > To: xen-devel@lists.xensource.com
> > Cc: Konrad Rzeszutek Wilk [konrad.wilk@oracle.com]
> > Subject: [PATCH] xen: add bridge check
> > 
> > Some SR-IOV devices may use more than one bus number, but there is no real
> > bridges
> > because that have internal routing mechanism. So need to check whether the
> > bridge is
> > existing before using it.
> > 
> > Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> > ---
> >  drivers/xen/pci.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> > index b84bf0b..18fff88 100644
> > --- a/drivers/xen/pci.c
> > +++ b/drivers/xen/pci.c
> > @@ -59,7 +59,7 @@ static int xen_add_device(struct device *dev)
> > 
> >  #ifdef CONFIG_ACPI
> >         handle = DEVICE_ACPI_HANDLE(&pci_dev->dev);
> > -       if (!handle)
> > +       if (!handle && pci_dev->bus->bridge)
> >             handle = DEVICE_ACPI_HANDLE(pci_dev->bus->bridge);
> >  #ifdef CONFIG_PCI_IOV
> >         if (!handle && pci_dev->is_virtfn)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  reply	other threads:[~2012-05-25  2:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25  2:05 [PATCH] xen: add bridge check Zhang, Yang Z
2012-05-25  2:28 ` Konrad Rzeszutek Wilk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-22  8:40 Zhang, Yang Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120525022818.GB27126@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.