All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: Josh Boyer <jwboyer@redhat.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	lantianyu1986@gmail.com
Subject: Re: USB device PM oddity in 3.5
Date: Fri, 25 May 2012 14:08:26 +0100	[thread overview]
Message-ID: <20120525130826.GA13258@srcf.ucam.org> (raw)
In-Reply-To: <4FBF826B.1040101@intel.com>

udev is being a little too aggressive in enabling autosuspend. I've just 
sent a patch upstream, but here it is:

commit 35c62663b93adb6ab321ca1e6ac6f1ba580b37aa
Author: Matthew Garrett <mjg@redhat.com>
Date:   Fri May 25 08:00:05 2012 -0400

    rules: Limit USB autosuspend on USB HID devices
    
    Some USB ports on external hubs may be reported as "fixed". We only want
    to auto-enable this on ports that are internal to the machine, so check
    the parent state as well.

diff --git a/rules/42-usb-hid-pm.rules b/rules/42-usb-hid-pm.rules
index d5d5897..fc44b94 100644
--- a/rules/42-usb-hid-pm.rules
+++ b/rules/42-usb-hid-pm.rules
@@ -46,4 +46,10 @@ ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="04b3", ATTR{idProduct}=="4012
 ACTION=="add", SUBSYSTEM=="usb", ATTR{idVendor}=="14dd", ATTR{idProduct}="0002", TEST=="power/control", ATTR{power/control}="auto"
 
 # USB HID devices that are internal to the machine should also be safe to autosuspend
+
+ACTION=="add", SUBSYSTEM=="usb", SUBSYSTEMS=="usb", ATTRS{removable}=="removable", GOTO="usb_hid_pm_end"
+ACTION=="add", SUBSYSTEM=="usb", SUBSYSTEMS=="usb", ATTRS{removable}=="unknown", GOTO="usb_hid_pm_end"        
+
 ACTION=="add", SUBSYSTEM=="usb", ATTR{bInterfaceClass}=="03", ATTRS{removable}=="fixed", TEST=="../power/control", ATTR{../power/control}="auto"
+
+LABEL="usb_add_pm_end"

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2012-05-25 13:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 20:36 USB device PM oddity in 3.5 Josh Boyer
2012-05-24 20:48 ` Alan Stern
2012-05-25 11:39   ` Josh Boyer
2012-05-25 11:41     ` Matthew Garrett
2012-05-25 11:45       ` Josh Boyer
2012-05-25 11:50         ` Josh Boyer
2012-05-25 11:56         ` Matthew Garrett
2012-05-25 13:00     ` Lan Tianyu
2012-05-25 13:08       ` Matthew Garrett [this message]
2012-05-25 14:27         ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120525130826.GA13258@srcf.ucam.org \
    --to=mjg@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jwboyer@redhat.com \
    --cc=lantianyu1986@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.