From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [Xen-devel] [PATCH 4/4] xen/events: Add WARN_ON when quick lookup found invalid type.
Date: Fri, 25 May 2012 09:42:31 -0400 [thread overview]
Message-ID: <20120525134231.GB21763@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205251018550.26786@kaball-desktop>
On Fri, May 25, 2012 at 10:19:10AM +0100, Stefano Stabellini wrote:
> On Fri, 25 May 2012, Stefano Stabellini wrote:
> > > @@ -939,8 +944,10 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
> > > xen_irq_info_virq_init(cpu, irq, evtchn, virq);
> > >
> > > bind_evtchn_to_cpu(evtchn, cpu);
> > > + } else {
> > > + struct irq_info *info = info_for_irq(irq);
> > > + WARN_ON(info == NULL || info->type != IRQT_VIRQ);
> > > }
> > > -
> > > out:
> > > mutex_unlock(&irq_mapping_update_lock);
> > >
> >
> > I don't want to nitpick but you removed 2 out of 3 spaced before the out
> > label.
>
> I meant newlines.
Good eyes! The final version will have those unmolested.
>
> > In any case:
> >
> > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >
prev parent reply other threads:[~2012-05-25 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 17:46 [PATCH] bug-fixes to hvc-xen driver in v3.4 (and earlier) Konrad Rzeszutek Wilk
2012-05-23 17:46 ` [PATCH 1/4] xen/hvc: Collapse error logic Konrad Rzeszutek Wilk
2012-05-24 10:33 ` Stefano Stabellini
2012-05-23 17:47 ` [PATCH 2/4] xen/hvc: Fix error cases around HVM_PARAM_CONSOLE_PFN Konrad Rzeszutek Wilk
2012-05-24 10:47 ` [Xen-devel] " Stefano Stabellini
2012-05-24 17:31 ` Konrad Rzeszutek Wilk
2012-05-24 18:18 ` Konrad Rzeszutek Wilk
2012-05-23 17:47 ` [PATCH 3/4] xen/hvc: Check HVM_PARAM_CONSOLE_[EVTCHN|PFN] for correctness Konrad Rzeszutek Wilk
2012-05-24 10:51 ` Stefano Stabellini
2012-05-24 18:24 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-25 9:13 ` Stefano Stabellini
2012-05-23 17:47 ` [PATCH 4/4] xen/events: Add WARN_ON when quick lookup found invalid type Konrad Rzeszutek Wilk
2012-05-24 10:58 ` [Xen-devel] " Stefano Stabellini
2012-05-24 17:29 ` Konrad Rzeszutek Wilk
2012-05-24 18:28 ` Konrad Rzeszutek Wilk
2012-05-25 9:18 ` Stefano Stabellini
2012-05-25 9:19 ` Stefano Stabellini
2012-05-25 13:42 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525134231.GB21763@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.