From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf record: Fixing record option data type in parse_branch_stack
Date: Fri, 25 May 2012 11:47:10 -0300 [thread overview]
Message-ID: <20120525144710.GG2336@infradead.org> (raw)
In-Reply-To: <4FBF5FAF.4010906@linux.vnet.ibm.com>
Em Fri, May 25, 2012 at 04:02:15PM +0530, Anshuman Khandual escreveu:
> On Friday 25 May 2012 02:14 PM, Stephane Eranian wrote:
>
> > Hi,
> >
> > It should be something like that instead:
> >
> > diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> > index 8a9687e..c9ca7c4 100644
> > --- a/tools/perf/perf.h
> > +++ b/tools/perf/perf.h
> > @@ -228,7 +228,7 @@ struct perf_record_opts {
> > unsigned int freq;
> > unsigned int mmap_pages;
> > unsigned int user_freq;
> > - int branch_stack;
> > + u64 branch_stack;
> > u64 default_interval;
> > u64 user_interval;
> > };
> >
>
>
>
> Agreed. I just tried to fix the problem where it was more evident because
> of the data type mismatch.
Can you send an updated patch on a message just for that?
- Arnaldo
next prev parent reply other threads:[~2012-05-25 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 9:21 perf record: why we used type casting of (uint64_t *) instead of int Anshuman Khandual
2012-05-25 5:27 ` Anshuman Khandual
2012-05-25 8:03 ` [PATCH] perf record: Fixing record option data type in parse_branch_stack Anshuman Khandual
2012-05-25 8:44 ` Stephane Eranian
2012-05-25 10:32 ` Anshuman Khandual
2012-05-25 14:47 ` Arnaldo Carvalho de Melo [this message]
2012-05-25 8:20 ` perf record: why we used type casting of (uint64_t *) instead of int Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525144710.GG2336@infradead.org \
--to=arnaldo.melo@gmail.com \
--cc=eranian@google.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.