From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH v2 09/14] block: Add an explicit bio flag for bios that own their bvec Date: Fri, 25 May 2012 13:01:23 -0700 Message-ID: <20120525200123.GA14196@google.com> References: <1337817771-25038-1-git-send-email-koverstreet@google.com> <1337817771-25038-10-git-send-email-koverstreet@google.com> <4FBE687E.1030605@panasas.com> <20120524213158.GB22664@google.com> <20120525164914.GE3855@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120525164914.GE3855-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vivek Goyal Cc: Boaz Harrosh , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org, yehuda-L5o5AL9CYN0tUFlbccrkMA@public.gmane.org List-Id: dm-devel.ids On Fri, May 25, 2012 at 12:49:14PM -0400, Vivek Goyal wrote: > Even if you keep it as it is, I thought BIO_OWNS_BVEC probably communicates > the idea better than BIO_HAS_BVEC. Yeah, I'll make that change. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.linbit.com (zimbra.linbit.com [212.69.161.123]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id D6E551012A92 for ; Fri, 25 May 2012 22:30:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.linbit.com (Postfix) with ESMTP id CDABA1B4315 for ; Fri, 25 May 2012 22:30:03 +0200 (CEST) Received: from zimbra.linbit.com ([127.0.0.1]) by localhost (zimbra.linbit.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cOCTTSBzd6tl for ; Fri, 25 May 2012 22:30:03 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra.linbit.com (Postfix) with ESMTP id A55331B40F5 for ; Fri, 25 May 2012 22:30:03 +0200 (CEST) Resent-Message-ID: <20120525203003.GC1903@soda.linbit> Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 33E2C100008C for ; Fri, 25 May 2012 22:01:28 +0200 (CEST) Received: by pbbro2 with SMTP id ro2so2872857pbb.27 for ; Fri, 25 May 2012 13:01:26 -0700 (PDT) Date: Fri, 25 May 2012 13:01:23 -0700 From: Kent Overstreet To: Vivek Goyal Message-ID: <20120525200123.GA14196@google.com> References: <1337817771-25038-1-git-send-email-koverstreet@google.com> <1337817771-25038-10-git-send-email-koverstreet@google.com> <4FBE687E.1030605@panasas.com> <20120524213158.GB22664@google.com> <20120525164914.GE3855@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120525164914.GE3855@redhat.com> Cc: axboe@kernel.dk, yehuda@hq.newdream.net, dm-devel@redhat.com, neilb@suse.de, linux-kernel@vger.kernel.org, tj@kernel.org, linux-bcache@vger.kernel.org, mpatocka@redhat.com, Boaz Harrosh , linux-fsdevel@vger.kernel.org, sage@newdream.net, agk@redhat.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH v2 09/14] block: Add an explicit bio flag for bios that own their bvec List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, May 25, 2012 at 12:49:14PM -0400, Vivek Goyal wrote: > Even if you keep it as it is, I thought BIO_OWNS_BVEC probably communicates > the idea better than BIO_HAS_BVEC. Yeah, I'll make that change. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964797Ab2EYUB3 (ORCPT ); Fri, 25 May 2012 16:01:29 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:45967 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757674Ab2EYUB1 (ORCPT ); Fri, 25 May 2012 16:01:27 -0400 Date: Fri, 25 May 2012 13:01:23 -0700 From: Kent Overstreet To: Vivek Goyal Cc: Boaz Harrosh , linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, tj@kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de, drbd-dev@lists.linbit.com, mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net Subject: Re: [PATCH v2 09/14] block: Add an explicit bio flag for bios that own their bvec Message-ID: <20120525200123.GA14196@google.com> References: <1337817771-25038-1-git-send-email-koverstreet@google.com> <1337817771-25038-10-git-send-email-koverstreet@google.com> <4FBE687E.1030605@panasas.com> <20120524213158.GB22664@google.com> <20120525164914.GE3855@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120525164914.GE3855@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 25, 2012 at 12:49:14PM -0400, Vivek Goyal wrote: > Even if you keep it as it is, I thought BIO_OWNS_BVEC probably communicates > the idea better than BIO_HAS_BVEC. Yeah, I'll make that change.