From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] libxl: When checking BDF of existing slots, function should be decimal, not hex
Date: Fri, 25 May 2012 16:27:58 -0400 [thread overview]
Message-ID: <20120525202758.GB23655@phenom.dumpdata.com> (raw)
In-Reply-To: <1c28051020488782f127.1337963657@exile>
On Fri, May 25, 2012 at 04:34:17PM +0000, George Dunlap wrote:
> # HG changeset patch
> # User George Dunlap <george.dunlap@eu.citrix.com>
> # Date 1337961666 0
> # Node ID 1c28051020488782f1277dd60a2418324580297e
> # Parent 69c3ae25bb1ddcb0ea44b7566d36d34e9d6a70aa
> libxl: When checking BDF of existing slots, function should be decimal, not hex
>
> Spotted-by: Konrad Wilk <konrad.wilk@oracle.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -480,7 +480,7 @@ static int pciback_dev_has_slot(libxl__g
> return ERROR_FAIL;
> }
>
> - while(fscanf(f, "%x:%x:%x.%x\n", &dom, &bus, &dev, &func)==4) {
> + while(fscanf(f, "%x:%x:%x.%d\n", &dom, &bus, &dev, &func)==4) {
> if(dom == pcidev->domain
> && bus == pcidev->bus
> && dev == pcidev->dev
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-05-25 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 16:34 [PATCH] libxl: When checking BDF of existing slots, function should be decimal, not hex George Dunlap
2012-05-25 20:27 ` Konrad Rzeszutek Wilk [this message]
2012-05-29 9:00 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525202758.GB23655@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.