Re: [Xen-devel] [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (v2)

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Fri, May 25, 2012 at 08:47:20PM +0000, Liu, Jinsong wrote:
> Konrad Rzeszutek Wilk wrote:
> >> What I mean is,
> >> If mcelog.c create /dev/xen-mcelog (say, minor=226), native mce.c
> >> would create /dev/mcelog (minor=227). 
> >> Under such case, may we create a symlink in /dev/mcelog pointing to
> >> /dev/xen-mcelog, without touching native mce code? and how? 
> > 
> > I thought the idea was that we would create /dev/mcelog using the
> > same major/minor. 
> 
> Our current patch just use same major/minor, by redirection method. Is it acceptable?

https://lkml.org/lkml/2012/5/24/183 Borislav says:
"
Maybe create a symlink in /dev/mcelog pointing to /dev/xen-mcelog?

That should solve it.
" so that sounds like the right direction.

> 
> > 
> > However if you want to create /dev/xen-mcelog and then create from
> > the kernel another file in /dev that is name 'mcelog' and is a
> > symlink to /dev/mcelog - that is OK too. Obviously you will also need
> > to disable the generic '/dev/mcelog' (and that can be done in the
> > same way as lguest does it). 
> 
> No, that's not my purpose.
> 
> Thanks,
> Jinsong