From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/4] perf top: Fix counter name fixup when fallbacking to cpu-clock
Date: Fri, 25 May 2012 18:30:45 -0300 [thread overview]
Message-ID: <20120525213045.GH2336@infradead.org> (raw)
In-Reply-To: <4FBFEAFA.8050004@gmail.com>
Em Fri, May 25, 2012 at 02:26:34PM -0600, David Ahern escreveu:
> The patch I sent had:
>
> + if (counter->name) {
> + free(counter->name);
> + counter->name = NULL;
> + counter->name = strdup(event_name(counter));
> + }
>
> See http://lkml.indiana.edu/hypermail/linux/kernel/1205.1/00390.html
I probably messed up this one, should've put a committer note for that
stupid simplification, anyway, just setting it to NULL is enough and
less confusing.
- Arnaldo
next prev parent reply other threads:[~2012-05-25 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 19:59 [GIT PULL 0/4] perf/urgent fixes Arnaldo Carvalho de Melo
2012-05-25 19:59 ` [PATCH 1/4] perf tools: Do not use _FORTIFY_SOURCE when DEBUG=1 is specified Arnaldo Carvalho de Melo
2012-05-25 19:59 ` [PATCH 2/4] perf tools: fix thread_map__new_by_pid_str() memory leak in error path Arnaldo Carvalho de Melo
2012-05-25 19:59 ` [PATCH 3/4] perf top: Fix counter name fixup when fallbacking to cpu-clock Arnaldo Carvalho de Melo
2012-05-25 20:26 ` David Ahern
2012-05-25 21:30 ` Arnaldo Carvalho de Melo [this message]
2012-05-25 19:59 ` [PATCH 4/4] perf tools: Reconstruct event with modifiers from perf_event_attr Arnaldo Carvalho de Melo
2012-05-25 21:46 ` [GIT PULL 0/4] perf/urgent fixes Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525213045.GH2336@infradead.org \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.