From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Walle <michael@walle.cc>
Date: Fri, 25 May 2012 21:54:51 +0200
Subject: [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()
In-Reply-To: <CANr=Z=Yo_wooTxVWLPycg65Q=DOxKr-BcdAYjXvnCmSAj6T9yQ@mail.gmail.com>
References: <1336776649-9316-1-git-send-email-michael@walle.cc>
	<201205172243.01110.michael@walle.cc>
	<CANr=Z=Yo_wooTxVWLPycg65Q=DOxKr-BcdAYjXvnCmSAj6T9yQ@mail.gmail.com>
Message-ID: <201205252154.51438.michael@walle.cc>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am Freitag 25 Mai 2012, 20:50:09 schrieb Joe Hershberger:
[..snip..]
> That way you aren't adding a function that noone else uses and you
> don't need a silly guard around it.

Hi Joe,

thanks for the review. I think i'll drop the dynamic "ethernet variable name" 
support entirely. Two reasons:
 - it isn't really dynamic, eg. the function always evaluates the name to
   "ethaddr"
 - back then when i wrote the support for the board the name was "eth1addr"
   and mike suggested to use the by index function for the getter and a new
   function for the setter. But i guess its not worth the hassle ;)

btw, imho your solution introduces a discrepancy between the setter and 
getter. i hope it doesnt bother you if i don't adapt your solution. But thanks 
for the work.

-- 
Michael