All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: git@vger.kernel.org, Luke Diamand <luke@diamand.org>
Subject: Re: [PATCHv2 0/3] New test cases for branch detection
Date: Sat, 26 May 2012 10:00:18 -0400	[thread overview]
Message-ID: <20120526140018.GA28962@padd.com> (raw)
In-Reply-To: <1338026166-5462-1-git-send-email-vitor.hda@gmail.com>

vitor.hda@gmail.com wrote on Sat, 26 May 2012 10:56 +0100:
> Updates for previous patch according to feedback from Pete Wyckoff (and
> some help from Junio). I also tried to find more improvement
> opportunities and included an extra small patch with two small fixes.
> 
> Please review and provide feedback.

These all look great to me, including the new fixes.

Acked-by: Pete Wyckoff <pw@padd.com>

		-- Pete

      parent reply	other threads:[~2012-05-26 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-26  9:56 [PATCHv2 0/3] New test cases for branch detection Vitor Antunes
2012-05-26  9:56 ` [PATCHv2 1/3] git-p4: Test changelists touching two branches Vitor Antunes
2012-05-26  9:56 ` [PATCHv2 2/3] git-p4: Verify detection of "empty" branch creation Vitor Antunes
2012-05-26  9:56 ` [PATCHv2 3/3] git-p4: Clean up branch test cases Vitor Antunes
2012-05-26 14:00 ` Pete Wyckoff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120526140018.GA28962@padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.