From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: use make rules to run tests in parallel (v2)
Date: Sun, 27 May 2012 21:18:10 -0400 [thread overview]
Message-ID: <20120528011810.GA19152@thunk.org> (raw)
In-Reply-To: <1337803760-20587-1-git-send-email-adilger@whamcloud.com>
On Wed, May 23, 2012 at 02:09:20PM -0600, Andreas Dilger wrote:
> Change the e2fsck/mke2fs/tune2fs/e2image/debugfs regression tests
> to be driven by Makefile rules instead of by a script loop. This
> allows the tests to be run in parallel like a build and reduces
> testing time significantly.
The makefile setup you've created has a fatal flaw; it completely
blows up if you are building with VPATH. That is, try this with your
patch: (starting with cwd in the e2fsprogs source tree)
% mkdir build
% cd build
% ../configure
% make
% make check
<boom>
Could you take a look at fixing this, please? I rely pretty
exclusively on building with VPATH (that way I can have a
build.static, build.32, etc.) with a single source tree.
- Ted
next prev parent reply other threads:[~2012-05-28 1:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1337776849-1138-1-git-send-email-adilger@whamcloud.com>
2012-05-23 12:48 ` [PATCH] tests: use make rules to run tests in parallel Andreas Dilger
2012-05-23 15:00 ` Ted Ts'o
2012-05-23 18:31 ` Andreas Dilger
2012-05-23 18:44 ` Andreas Dilger
2012-05-23 20:09 ` [PATCH] tests: use make rules to run tests in parallel (v2) Andreas Dilger
2012-05-28 1:18 ` Ted Ts'o [this message]
2012-05-28 23:48 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528011810.GA19152@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.