Re: [PATCH 2/5] ASoC: core: Add widget SND_SOC_DAPM_CLOCK_SUPPLY

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 807 bytes --]

On Thu, May 24, 2012 at 03:26:25PM +0200, Ola Lilja wrote:
> Adds a supply-widget variant for connection to the clock-framework.
> This widget-type corresponds to the variant for regulators.

I'll apply this but...

> +	case snd_soc_dapm_clock_supply:
> +		w->clk = clk_get(dapm->dev, w->name);
> +		if (IS_ERR(w->clk)) {
> +			ret = PTR_ERR(w->clk);
> +			dev_err(dapm->dev, "Failed to request %s: %d\n",
> +				w->name, ret);
> +			return NULL;

Should be devm_clk_get() (which will be there after the merge window)
but I'll fix that up once the merge window sorts itself out.

We'll also need to work out how this works with the clk API not being
generally available but that'll partly depend on the clk API stubs - if
they're in -rc1 there should be no problem otherwise we'll need ifdefs
or something.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]