All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2fs: remove 64-bit wrappers from ext2fs.h (v2)
Date: Mon, 28 May 2012 10:56:21 -0400	[thread overview]
Message-ID: <20120528145621.GF19152@thunk.org> (raw)
In-Reply-To: <1337991801-29500-1-git-send-email-adilger@whamcloud.com>

On Fri, May 25, 2012 at 06:23:21PM -0600, Andreas Dilger wrote:
> The creation of inline wrappers ext2fs_open() and ext2fs_stat()
> in commit c859cb1de0d624caa0779fb17d1a53766143136e in ext2fs.h
> caused difficulties with the use of headers, since the headers
> for open64() and stat64() may already be included (and skip the
> declaration of the 64-bit variants) before ext2fs.h is ever read.
> There is no real way to solve the missing prototypes and resulting
> compiler warnings inside ext2fs.h.
> 
> Since ext2fs_open() and ext2fs_stat() are not performance critical
> operations, they do not need to be inline functions at all, and
> the needed function headers can be handled properly in one file.
> 
> Similarly, posix_memalloc() was having difficulties with headers,
> and was being defined in ext2fs.h, but it is now only being used
> by a single file, so move the required header there.
> 
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>

Applied, with a lightly edited commit description.  This commit is now
entitled:

   libext2fs: don't inline ext2fs_open_file() and ext2fs_stat()

							- Ted

      reply	other threads:[~2012-05-28 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 22:13 [PATCH] ext2fs: remove 64-bit wrappers from ext2fs.h Andreas Dilger
2012-05-26  0:23 ` [PATCH] ext2fs: remove 64-bit wrappers from ext2fs.h (v2) Andreas Dilger
2012-05-28 14:56   ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120528145621.GF19152@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@whamcloud.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.